test: test query fields with only a measurement predicate #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchikwekwe
suggested changes
Jul 29, 2021
There was a problem hiding this comment.
@wbaker85 we've been migrating our existing end to end tests to a newer format that uses the testcase keyword instead of the test keyword. I don't think we have a guide for this yet, but here's an example https://github.com/influxdata/flux/blob/master/stdlib/universe/pivot_table_test.flux. Happy to pair if you need help converting your test.
fchikwekwe
approved these changes
Jul 29, 2021
williamhbaker
force-pushed
the
wb-fields-with-meas-pred-test
branch
from
6760ddb to
c879e5e
Compare
williamhbaker
force-pushed
the
wb-fields-with-meas-pred-test
branch
from
c879e5e to
93dbc4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on influxdata/influxdb#21962, I found that the existing
show_fields_xxx.fluxtests did not include one where there is only a single predicate of_measurement.show_fields_with_pred_test.fluxhas a predicate of_measurementas well as one for an additional tag, andshow_fields_test.fluxdoes not have a filter.This additional test will cover the case of only having a predicate of
_measurement. It is primarily useful to me since I am planning to tweak the OSS logic related to a query like this.