Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(stdlib): add more metaquery tests #3272

Merged
merged 1 commit into from
Oct 23, 2020
Merged

test(stdlib): add more metaquery tests #3272

merged 1 commit into from
Oct 23, 2020

Conversation

wolffcm
Copy link

@wolffcm wolffcm commented Oct 22, 2020

These add tests that exercise the tagValues and tagKeys storage APIs.

This is in response to an issue found after upgrading Flux in OSS:
influxdata/influxdb#19561

And also two issues that were filed as a result of that issue:
influxdata/influxdb#19794
influxdata/influxdb#19806

The new tests added here would fail if PushDownReadTagValuesRule and PushDownReadTagKeysRule were re-enabled in OSS, so they will serve as useful regression tests for the above issues.

Fixes influxdata/influxdb#19561.

(Doesn't actually fix it, but I want that issue closed when this merges)

@codecov-io
Copy link

Codecov Report

Merging #3272 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3272      +/-   ##
==========================================
- Coverage   49.64%   49.63%   -0.01%     
==========================================
  Files         344      344              
  Lines       35855    35855              
==========================================
- Hits        17799    17797       -2     
- Misses      15582    15583       +1     
- Partials     2474     2475       +1     
Impacted Files Coverage Δ
stdlib/universe/pivot.gen.go 9.66% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ea803e...8b7b2cb. Read the comment docs.

@wolffcm wolffcm merged commit a94d161 into master Oct 23, 2020
@wolffcm wolffcm deleted the test/tag-keys branch October 23, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bugs and reenable PushDownReadTagValuesRule and PushDownReadTagKeysRule
3 participants