Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(stdlib/planner): test readGroup max/min #3051

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

fchikwekwe
Copy link
Contributor

Done checklist

  • docs/SPEC.md updated
  • Test cases written

@fchikwekwe fchikwekwe force-pushed the test/read-group-min-max branch 3 times, most recently from 97f11c9 to d5affbe Compare July 29, 2020 17:46
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #3051 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3051      +/-   ##
==========================================
- Coverage   51.70%   51.69%   -0.01%     
==========================================
  Files         331      331              
  Lines       41347    41347              
==========================================
- Hits        21377    21375       -2     
- Misses      17510    17511       +1     
- Partials     2460     2461       +1     
Impacted Files Coverage Δ
stdlib/universe/pivot.gen.go 9.93% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de98617...732dfc6. Read the comment docs.

@fchikwekwe fchikwekwe force-pushed the test/read-group-min-max branch from 224d29c to bb30d3b Compare July 29, 2020 18:41
@fchikwekwe fchikwekwe marked this pull request as ready for review July 29, 2020 19:13
@fchikwekwe fchikwekwe force-pushed the test/read-group-min-max branch from bb30d3b to 732dfc6 Compare July 30, 2020 17:13
@fchikwekwe fchikwekwe requested review from a team and ChitlangeSahas and removed request for a team July 31, 2020 18:15
@fchikwekwe fchikwekwe merged commit 0623135 into master Jul 31, 2020
@fchikwekwe fchikwekwe deleted the test/read-group-min-max branch July 31, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants