Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Optional Graphic to FunnelPage #470

Merged
merged 5 commits into from
Mar 20, 2020
Merged

Add Optional Graphic to FunnelPage #470

merged 5 commits into from
Mar 20, 2020

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Mar 20, 2020 •
edited
Loading

Closes #455

Changes

  • Add optional enableGraphic prop to FunnelPage
  • Update build configs to handle image loading (shout out to @hoorayimhelping )

Screenshots

Screen Shot 2020-03-20 at 1 48 19 PM

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from mavarius March 20, 2020 20:48
@alexpaxton alexpaxton mentioned this pull request Mar 20, 2020
Closed
3 tasks
mavarius
mavarius approved these changes Mar 20, 2020
View reviewed changes
Copy link
Collaborator

@mavarius mavarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, just also a note that we'll need to eventually find a more robust way of handling image asset rollups.

@alexpaxton alexpaxton merged commit f5849f3 into master Mar 20, 2020
@alexpaxton alexpaxton deleted the feat/funnel-page-image branch March 20, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavarius mavarius mavarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Graphic to Funnel Page
3 participants
@alexpaxton @mavarius @hoorayimhelping