Frontend libs 13 migration guide #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goranalkovic-infinum
added
dependencies
iruzevic
reviewed
Jul 27, 2024
|
|
||
| These helpers should be imported from `@eightshift/ui-components/utilities` instead of Frontend libs: | ||
| - `camelize` → `camelCase` | ||
| - `classnames` → `clsx` |
There was a problem hiding this comment.
we should make these changes for the libs also?
There was a problem hiding this comment.
They'll be made, but that's within FE libs, not docs 😄
dadadavorin
previously approved these changes
Jul 29, 2024
iobrado
previously approved these changes
Jul 29, 2024
website/docs/migrations/12-13.md
Outdated
| ## Helpers | ||
|
|
||
| ### Removed helpers | ||
| Some helpers were deprecated and removed, without a replacement. If they were used in the project before, you can take the source of the helper from Frontend libs 12 and included it in your project. |
There was a problem hiding this comment.
Suggested change
| Some helpers were deprecated and removed, without a replacement. If they were used in the project before, you can take the source of the helper from Frontend libs 12 and included it in your project. | |
| Some helpers were deprecated and removed, without a replacement. If they were used in the project before, you can take the source of the helper from Frontend libs 12 and include it in your project. |
piqusy
previously approved these changes
Jul 31, 2024
goranalkovic-infinum
dismissed stale reviews from piqusy, iobrado, and dadadavorin
via
0e9e13d
goranalkovic-infinum
requested review from
iruzevic,
dadadavorin,
iobrado and
piqusy
piqusy
approved these changes
Aug 7, 2024
iruzevic
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: