Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to pass the already created axios instance in the config #222

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Add the ability to pass the already created axios instance in the config #222

merged 1 commit into from
Aug 20, 2019

Conversation

max-lychko
Copy link
Contributor

This PR add the ability to pass the already created axios instance in the config. This is issue #205.

ryanlntn
ryanlntn approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@ryanlntn ryanlntn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

robinheinze
robinheinze approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@robinheinze robinheinze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@robinheinze robinheinze merged commit fd286c1 into infinitered:master Aug 20, 2019
@max-lychko
Copy link
Contributor Author

max-lychko commented Aug 20, 2019 •
edited
Loading

Thanks, guys 🙂 I will also create a PR with the README.md update for this feature

@max-lychko max-lychko mentioned this pull request Aug 21, 2019
Merged
@infinitered-circleci
Copy link

🎉 This PR is included in version 1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@popbee
Copy link

popbee commented Aug 23, 2019

Typescript:
axiosInstance is optional. The syntax for "optional" in Typescript is ?. This is very different from | undefined. This is forcing Typescript users to adapt the code when upgrading to add a dummy axiosInstance with the value undefined.

This is not backward compatible. Either we fix the types or upgrade the version accordingly (semver).

@ryanlntn ryanlntn mentioned this pull request Aug 23, 2019
Merged
@robinheinze
Copy link
Member

Thanks @popbee, you're very right. Just released a new patch with the correct type definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanlntn ryanlntn ryanlntn approved these changes

@robinheinze robinheinze robinheinze approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@max-lychko @infinitered-circleci @popbee @robinheinze @ryanlntn