Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Vue 2 EOL integration tests to Vue 3 #1873

Closed
wants to merge 3 commits into from

Conversation

jamesst20
Copy link
Contributor

@jamesst20 jamesst20 commented May 12, 2024

Vue 2 being EOL, tests should be upgraded to Vue 3.

  • Every packages used for the tests are up to date
  • Made no unnecessary edits to the tests
  • Tests are pretty close to identical to Vue 2 version
  • Updated github workflow

Goal: Give the possibility to drop Vue 2 adapter painlessly. Vue 2 adapter is outdated and preventing update to the latest NodeJS LTS in the workflow.

Visual differences between tests from Vue2 and Vue3

Capture d’écran, le 2024-05-11 à 20 59 09
Capture d’écran, le 2024-05-11 à 20 59 23
Capture d’écran, le 2024-05-11 à 20 59 38
Capture d’écran, le 2024-05-11 à 20 59 58
Capture d’écran, le 2024-05-11 à 21 00 13
Capture d’écran, le 2024-05-11 à 21 00 55

jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 12, 2024
[inertiajs#1873] Migrate Vue 2 EOL integration tests to Vue 3
jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 12, 2024
[inertiajs#1873] Migrate Vue 2 EOL integration tests to Vue 3
jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 28, 2024
[inertiajs#1873] Migrate Vue 2 EOL integration tests to Vue 3
jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 28, 2024
[inertiajs#1873] Migrate Vue 2 EOL integration tests to Vue 3
@jamesst20
Copy link
Contributor Author

It appears to me the project Inertia is dead and there are no more reasons for me to keep my work open and maintain it.

I am closing all my opened PRs which includes #1864 #1872 #1873 #1874 #1875 #1881

I will be maintaining unofficially my own fork of this library so my projects using Svelte 5 can still live until I find or create an appropriate replacement for this library.

Thanks to everyone who spent time looking at my PRs.

@reinink
Copy link
Member

reinink commented Sep 2, 2024

It appears to me the project Inertia is dead and there are no more reasons for me to keep my work open and maintain it.

I am closing all my opened PRs which includes #1864 #1872 #1873 #1874 #1875 #1881

I will be maintaining unofficially my own fork of this library so my projects using Svelte 5 can still live until I find or create an appropriate replacement for this library.

Thanks to everyone who spent time looking at my PRs.

Bummer dude 😕

We've been working really hard on Inertia.js v2.0 (as you can see in Taylor's Laracon keynote), so the project is far from dead — we're just in a bit of an awkward position between major versions.

I apologize that your work has not received more attention, that's partly my fault for not having enough time to review PRs recently. I don't work on Inertia.js full time like other open source maintainers (ie. Laravel, Livewire), so for me it actually requires time out of my personal life. Because of that things just take longer, as much as I wish it didn't.

Thanks for your contributions either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants