Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdobeRGB images are dull #3136

Closed
1 of 3 tasks
uhthomas opened this issue Jul 6, 2023 · 2 comments · Fixed by #3658
Closed
1 of 3 tasks

AdobeRGB images are dull #3136

uhthomas opened this issue Jul 6, 2023 · 2 comments · Fixed by #3658

Comments

@uhthomas
Copy link
Member

uhthomas commented Jul 6, 2023

The bug

It seems like images within the AdobeRGB colour space have dull thumbnails.

See this side-by-side comparison of the same image rendered by Geeqie and Immich.

image

lovell/sharp#1114 seems related, maybe it's as simple as asking sharp to use the inbuilt profile?

The OS that Immich Server is running on

N/A

Version of Immich Server

v1.65.0

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

N/A

Additional information

No response

uhthomas added a commit that referenced this issue Jul 8, 2023
Include metadata with thumbnails, including a "web-friendly sRGB ICC profile".

https://sharp.pixelplumbing.com/api-output#withmetadata

Fixes: #3136
uhthomas added a commit that referenced this issue Jul 8, 2023
Include metadata with thumbnails, including a "web-friendly sRGB ICC profile".

https://sharp.pixelplumbing.com/api-output#withmetadata

Fixes: #3136
@AngelaDMerkel
Copy link
Contributor

AngelaDMerkel commented Aug 10, 2023

This is likely caused by Immich converting proxy/thumbnails to sRGB and is the same as my feature request #3623

@uhthomas
Copy link
Member Author

This is likely caused by Immich converting proxy/thumbnails to sRGB and is the same as my feature request #3623

It's a little more complicated than that. It's not a problem that images are converted to sRGB, it's just they are converted really badly. Per #3164 (comment), it's possible to convert to sRGB with good results. It just needs a bit of tinkering to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants