Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update immer.d.ts #131

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Update immer.d.ts #131

merged 1 commit into from
Mar 26, 2018

Conversation

dmorosinotto
Copy link
Contributor

I changed the return type of recipe to void | S to correctly type check the use-case of producers that return new state as shown in the samples of returning data from producers in the readme docs

@dmorosinotto
Update immer.d.ts
9694104 
to correctly type check the use-case of producers that return new state
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.296% when pulling 9694104 on dmorosinotto:patch_dts into 38ebb75 on mweststrate:master.

@mweststrate
Copy link
Collaborator

Thanks!

@mweststrate mweststrate merged commit 2cd32e0 into immerjs:master Mar 26, 2018
@dmorosinotto
Copy link
Contributor Author

You are welcome!
Hope to see the output of new develop #128 to directly use TS in source code, so maybe in the future you can automatically produce d.ts and keep it in sync with the library 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmorosinotto @coveralls @mweststrate