Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not throw an error when deleting a non-existant prop from draft #1031

Closed
wants to merge 1 commit into from

Conversation

skratchdot
Copy link

@skratchdot skratchdot commented Apr 6, 2023

This should fix the issue found here:
#1015 (comment)

https://codesandbox.io/s/flamboyant-glitter-n2nevz?file=/src/App.js

cc @einarq / @mweststrate

The only concern I have: I did not look into how this library is being transpiled, or if "optional chaining" is used elsewhere in the code. This change did appear to "fix" the new unit test I added

@skratchdot skratchdot force-pushed the immer-10-delete-fix branch from 48fa317 to 189b382 Compare April 6, 2023 12:23
@coveralls
Copy link

coveralls commented Apr 6, 2023

Pull Request Test Coverage Report for Build 4628822574

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 99.697%

Totals Coverage Status
Change from base Build 4623170994: -0.1%
Covered Lines: 641
Relevant Lines: 642

💛 - Coveralls

@skratchdot skratchdot closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants