-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable nullable references... and other stuff. #691
Conversation
…d ExpiringTokenFilter.
Agent/Services/FileLogsManager.cs
Outdated
} | ||
} | ||
|
||
public async IAsyncEnumerable<byte[]> ReadAllBytes() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now reads all files instead of only today's. Returns IAsyncEnumerable
so it doesn't have to load all files into memory at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add a cancellation token parameter here, with the EnumeratorCancellation attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I added it for all the methods in this class.
Agent/Services/FileLogsManager.cs
Outdated
} | ||
} | ||
|
||
public async IAsyncEnumerable<byte[]> ReadAllBytes() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add a cancellation token parameter here, with the EnumeratorCancellation attribute?
Unfortunately, this is the ultimate "while you're in there" PR.
FileLogger
toIFileLogsManager
.IFileLogsManager
read all log files and return them asIAsyncEnumerable
, so it's not loading everything into memory.X-Api-Key
header.ApiAuthorizationFilter
andExpiringTokenFilter
.Please read the following. Do not delete below this line.
Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.
This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.
While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:
A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/
By submitting this PR, you agree to the following: