Use recommended policy-based authorization for Org Admin and Server Admin pages. #662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as fixing the Server Logs page. The loading screen wasn't showing initially, because the
LoaderHarness
needed to register for events earlier in the component lifecycle.Then wanted to fix one of the many tech debt items that have been bothering me for a while. The pages requiring Org Admin and Server Admin rights (derived from
AuthComponentBase
) were conditionally including/excluding content directly in the page based on the current user.I changed these pages to use the recommended policy-based authorization approach, and added them to the pages
Authorize
tag. This lets theAuthorizeView
in the app's router handle authorization for all the pages and displays the same template when not authorized.Also fixed a bug causing the device to not update on heartbeat.
Please read the following. Do not delete below this line.
Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.
This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.
While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:
A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/
By submitting this PR, you agree to the following: