Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/finished/iia 1273 semantic purpose and meaning #267

Merged

Conversation

bhharsh13
Copy link
Contributor

Fixed the Semantic meaning and Semantic purpose text overlap issue.

https://ikmdev.atlassian.net/browse/IIA-1273

Validated the changes locally. Please help to review the PR.

Before resizing the Pattern
Before resizing Pattern
After resizing the Pattern, text doesn't overlap for both.
After resizing Pattern - no text overlap

Copy link
Contributor

@carldea carldea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I like how both columns are responsive and honors the parent's available width. Mastering layout is hard and is always different depending on the scenario.

@bhharsh13 bhharsh13 merged commit 44aab26 into ikmdev:main Feb 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants