Feature/finished/iia 1112 image data type #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly showing on first time
# Conflicts: # kview/src/main/java/dev/ikm/komet/kview/klfields/KlFieldHelper.java
stenkarl
reviewed
Feb 6, 2025
kview/src/main/java/dev/ikm/komet/kview/klfields/imagefield/KlImageFieldFactory.java
Outdated
Show resolved
Hide resolved
stenkarl
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://ikmdev.atlassian.net/browse/IIA-1112
This PR adds in Image Data type in Komet. The image data type is hardcode, nothing is fetched from the database as we don't have that capability yet in the DB.
For now, there was no need to restrict the type of images that can be added but the file dialog does restrict the users choice to only images.
It will only show in one of the test semantics.
I've attached a video to the Jira ticket given it was too big for Github.
Update 06/02/2025: Image file name UI has been removed from the UI in light of today's discussion with Amplified and PR has been updated accordingly