Test issue #1 #1
Comments
|
Edited by proposal-police: This proposal was added at 2024-01-28 18:50:50 UTC. Proposal What is the root cause of that problem? We're using cursor: pointer on the task description label. But due to the fact that the input container has styles.textInputMultilineContainer which is paddingTop: 23, and the container inherits the GenericPressable's cursor.pointer styles because: on this line there's no accesibilityRole or role passed down to the GenericPressable therefore we get the cursor.pointer and we see the pointer cursor. What changes do you think we should make in order to solve the problem? To do this, within BaseTextInput we have to pass down the role prop to the PressableWithoutFeedback. This will make it such that the inherited cursor will be default instead of pointer. What alternative solutions did you explore? (Optional) |
|
Proposal What is the problem ? Some problem. What is the root cause ? Everything. Solution ? Test solution. |
|
@ikevin127 Your proposal will be dismissed because you did not follow the proposal template. |
|
@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal using the proposal template. |
|
Edited by proposal-police: This proposal was edited at 2025-01-10 02:23:39 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue"It's not here" page shows up briefly when deleting a track expense. What is the root cause of that problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. What changes do you think we should make in order to solve the problem?Note As one can note regarding the other issue's result video below, we do indeed see a Not found page screen briefly (similar to this issue) after reverting the fix but I don't consider that an issue given we're in Debug mode and more importantly the behaviour is present on current staging (meaning no tradeoff). What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?N/A. |
ProposalPlease re-state the problem that we are trying to solve in this issue"It's not here" page shows up briefly when deleting a track expense. What is the root cause of that problem?I don't know root cause as of now. What changes do you think we should make in order to solve the problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. Note As one can note regarding the other issue's result video below, we do indeed see a Not found page screen briefly (similar to this issue) after reverting the fix but I don't consider that an issue given we're in Debug mode and more importantly the behaviour is present on current staging (meaning no tradeoff). What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?doesn't apply |
|
@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal using the proposal template. |
ProposalPlease re-state the problem that we are trying to solve in this issue"It's not here" page shows up briefly when deleting a track expense. What is the root cause of that problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. What changes do you think we should make in order to solve the problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. Note As one can note regarding the other issue's result video below, we do indeed see a Not found page screen briefly (similar to this issue) after reverting the fix but I don't consider that an issue given we're in Debug mode and more importantly the behaviour is present on current staging (meaning no tradeoff). What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?none |
|
Proposal What is the problem ? Testing updated assistant proposal enforcement message. What is the root cause ? Everything. |
|
@ikevin127 Thanks for your proposal. To be reviewed by Contributor+, please update your proposal using the proposal template. |
|
🚨 Edited by proposal-police: This proposal was edited at 2025-01-10 22:55:38 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue"It's not here" page shows up briefly when deleting a track expense. What is the root cause of that problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue. What changes do you think we should make in order to solve the problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. Note As one can note regarding the other issue's result video below, we do indeed see a Not found page screen briefly (similar to this issue) after reverting the fix but I don't consider that an issue given we're in Debug mode and more importantly the behaviour is present on current staging (meaning no tradeoff). What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?none |
|
Proposal What is the problem ? Testing updated assistant proposal enforcement message. What is the root cause ? Everything. |
|
|
ProposalPlease re-state the problem that we are trying to solve in this issue"It's not here" page shows up briefly when deleting a track expense. What is the root cause of that problem?The RC of this issue comes from the fix implemented by this PR: Expensify/App#51920 which when we delete the track expense is false (initially) -> causing the if to not pass -> resulting in the only passing if being the shouldShowNotFoundPage one here: which renders the It's not here page in our case. What changes do you think we should make in order to solve the problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. Note As one can note regarding the other issue's result video below, we do indeed see a Not found page screen briefly (similar to this issue) after reverting the fix but I don't consider that an issue given we're in Debug mode and more importantly the behaviour is present on current staging (meaning no tradeoff). What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?Test the solution implementation for the revert. |
|
Proposal What is the problem ? Testing updated assistant proposal enforcement message. What is the root cause ? Everything. |
|
Proposal looks good 👍 |
|
Proposal What is the problem ? Testing updated assistant proposal enforcement message. What is the root cause ? Everything. |
|
|
|
Proposal looks good 👍 |
|
Proposal What is the problem ? Testing updated assistant proposal enforcement message. What is the root cause ? Everything. |
|
|
|
🚨 Edited by proposal-police: This proposal was edited at 2025-01-11 00:36:41 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue"It's not here" page shows up briefly when deleting a track expense. What is the root cause of that problem?Some sort of a root cause. What changes do you think we should make in order to solve the problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. Note As one can note regarding the other issue's result video below, we do indeed see a Not found page screen briefly (similar to this issue) after reverting the fix but I don't consider that an issue given we're in Debug mode and more importantly the behaviour is present on current staging (meaning no tradeoff). What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?Test the solution implementation for the revert. |
|
Proposal What is the problem ? Testing updated assistant proposal enforcement message. What is the root cause ? Everything. |
|
|
|
🚨 Edited by proposal-police: This proposal was edited at 2025-01-11 03:00:57 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue"It's not here" page shows up briefly when deleting a track expense. What is the root cause of that problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. What changes do you think we should make in order to solve the problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. Note As one can note regarding the other issue's result video below, we do indeed see a Not found page screen briefly (similar to this issue) after reverting the fix but I don't consider that an issue given we're in Debug mode and more importantly the behaviour is present on current staging (meaning no tradeoff). What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?Test the solution implementation for the revert. |
|
|
|
🚨 Edited by proposal-police: This proposal was edited at 2025-01-11 02:56:24 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue"It's not here" page shows up briefly when deleting a track expense. What is the root cause of that problem?ABC What changes do you think we should make in order to solve the problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. Note As one can note regarding the other issue's result video below, we do indeed see a Not found page screen briefly (similar to this issue) after reverting the fix but I don't consider that an issue given we're in Debug mode and more importantly the behaviour is present on current staging (meaning no tradeoff). What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?Test the solution implementation for the revert. |
ProposalPlease re-state the problem that we are trying to solve in this issue"It's not here" page shows up briefly when deleting a track expense. What is the root cause of that problem?ABC What changes do you think we should make in order to solve the problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. Note As one can note regarding the other issue's result video below, we do indeed see a Not found page screen briefly (similar to this issue) after reverting the fix but I don't consider that an issue given we're in Debug mode and more importantly the behaviour is present on current staging (meaning no tradeoff). What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future? |
|
|
ProposalPlease re-state the problem that we are trying to solve in this issue"It's not here" page shows up briefly when deleting a track expense. What is the root cause of that problem?ABC What changes do you think we should make in order to solve the problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. Note As one can note regarding the other issue's result video below, we do indeed see a Not found page screen briefly (similar to this issue) after reverting the fix but I don't consider that an issue given we're in Debug mode and more importantly the behaviour is present on current staging (meaning no tradeoff). What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future? |
|
🚨 Edited by proposal-police: This proposal was edited at 2025-01-15 23:44:11 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue"It's not here" page shows up briefly when deleting a track expense. What is the root cause of that problem?Offending PR being reverted. What changes do you think we should make in order to solve the problem?Revert the changes implemented by PR Expensify/App#51920 which would fix this issue and from my tests looks like the other issue (Expensify/App#51388) would not be reproducible anymore even with the fix implemented by the offending PR being reverted. Note As one can note regarding the other issue's result video below, we do indeed see a Not found page screen briefly (similar to this issue) after reverting the fix but I don't consider that an issue given we're in Debug mode and more importantly the behaviour is present on current staging (meaning no tradeoff). What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?N/A |
|
|
No description provided.
The text was updated successfully, but these errors were encountered: