Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write ThermalHouse results when em controlled #845

Merged
merged 19 commits into from
Jul 25, 2024
Merged

Write ThermalHouse results when em controlled #845

merged 19 commits into from
Jul 25, 2024

Conversation

danielfeismann
Copy link
Member

@danielfeismann danielfeismann commented Jul 3, 2024 •
edited
Loading

merge #842 first

resolves #844

@danielfeismann danielfeismann self-assigned this Jul 3, 2024
@danielfeismann danielfeismann added the bug Something isn't working label Jul 3, 2024
@danielfeismann danielfeismann marked this pull request as ready for review July 4, 2024 08:55
@danielfeismann danielfeismann removed the request for review from staudtMarius July 12, 2024 08:50
@staudtMarius
Copy link
Member

@danielfeismann There is a test failing in StorageAgentModelCalculationSpec.

@danielfeismann
Copy link
Member Author

danielfeismann commented Jul 12, 2024 •
edited
Loading

@danielfeismann There is a test failing in StorageAgentModelCalculationSpec.

Yes, thanks. This arised after merging the new storage pr into dev. Working on it.

Edit: Should be fine now.

@danielfeismann danielfeismann mentioned this pull request Jul 17, 2024
Closed
jo-bao
jo-bao previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@jo-bao jo-bao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it looks good!

jo-bao
jo-bao approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@jo-bao jo-bao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@danielfeismann danielfeismann merged commit bf12f50 into dev Jul 25, 2024
4 checks passed
@danielfeismann danielfeismann deleted the df/#844_fix_thermal_house_results branch July 25, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jo-bao jo-bao jo-bao approved these changes

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

Assignees

@danielfeismann danielfeismann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write ThermalHouse results when em controlled
3 participants
@danielfeismann @staudtMarius @jo-bao