Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload figures #153

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Upload figures #153

merged 1 commit into from
Feb 28, 2022

Conversation

danielfeismann
Copy link
Member

Resolves #151

@danielfeismann danielfeismann self-assigned this Feb 24, 2022
@danielfeismann danielfeismann added the documentation Improvements or additions to documentation label Feb 24, 2022
@danielfeismann danielfeismann added this to the Version 3.0 milestone Feb 24, 2022
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • No coverage informationNo coverage information (81.50% Estimated after merge)
  • No duplication informationNo duplication information (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #153 (fb3e036) into dev (6acd7d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #153   +/-   ##
=======================================
  Coverage   79.24%   79.24%           
=======================================
  Files         155      155           
  Lines        5725     5725           
  Branches       79       79           
=======================================
  Hits         4537     4537           
  Misses       1188     1188           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6acd7d3...fb3e036. Read the comment docs.

Copy link
Member

@johanneshiry johanneshiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you change the design? Although looks good to me. Thank you!

@danielfeismann
Copy link
Member Author

Did you change the design? Although looks good to me. Thank you!

Design change was not intended, but maybe I used a different puml to png converter than usual?

@ckittl
Copy link
Member

ckittl commented Feb 28, 2022

LGTM, too. However, we might consider using svg files on the long run (cf. #156).

@ckittl ckittl merged commit bd62a30 into dev Feb 28, 2022
@ckittl ckittl deleted the df/#151-Missing-Images-RTD branch February 28, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Images in RTD Documentation
3 participants