Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make passing a refSystem via the configuration optional #769

Closed
t-ober opened this issue Mar 11, 2024 · 0 comments · Fixed by #780
Closed

Make passing a refSystem via the configuration optional #769

t-ober opened this issue Mar 11, 2024 · 0 comments · Fixed by #780
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@t-ober
Copy link
Contributor

t-ober commented Mar 11, 2024

Currently we need to pass a refSystem explicitly via the configuration:

  gridConfig {
    refSystems = [
      {
        sNom = "60 MVA"
        vNom = "10 kV"
        voltLvls = [
          {
            id = "MS"
            vNom = "10 kV"
          }
        ]
      }

I don't see why we can't make that optional and use sensible standard values so the user do not have to care about that if they don't want to.

@t-ober t-ober added enhancement New feature or request good first issue Good for newcomers labels Mar 11, 2024
@staudtMarius staudtMarius self-assigned this Apr 4, 2024
danielfeismann added a commit that referenced this issue Apr 24, 2024
…via-config-optional

# Conflicts:
#	CHANGELOG.md
danielfeismann added a commit that referenced this issue Apr 24, 2024
…fSystem-via-config-optional

Making passing of `RefSystem` via config optional.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants