Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve some compiler warnings #657

Closed
sebastian-peter opened this issue Nov 20, 2023 · 0 comments · Fixed by #723
Closed

Solve some compiler warnings #657

sebastian-peter opened this issue Nov 20, 2023 · 0 comments · Fixed by #723
Assignees
@staudtMarius
Labels
code quality Code readability or efficiency is improved

Comments

@sebastian-peter
Copy link
Member

sebastian-peter commented Nov 20, 2023 •
edited
Loading

There's some compiler warnings that are not critical, but could count as "code smells". Not all of them are worth it solving (or can easily be solved), but I believe the ones of the following types can be:

  • BigDecimalDoubleConstructor
  • "reference to $x is ambiguous"
  • "match may not be exhaustive"

Furthermore, some deprecations (gzip, withFirstRecordAsHeader) could possibly be solved (although this might take some more tinkering).
@sebastian-peter sebastian-peter added good first issue Good for newcomers code quality Code readability or efficiency is improved labels Nov 20, 2023
@sebastian-peter sebastian-peter removed the good first issue Good for newcomers label Dec 13, 2023
@staudtMarius staudtMarius self-assigned this Feb 5, 2024
@staudtMarius staudtMarius mentioned this issue Feb 5, 2024
Merged
sebastian-peter added a commit that referenced this issue Feb 6, 2024
@sebastian-peter
Merge pull request #723 from ie3-institute/ms/#657-solve-some-compile…
20cad05 
…r-warnings

Solving some compiler warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staudtMarius staudtMarius

Labels
code quality Code readability or efficiency is improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solving some compiler warnings. ie3-institute/simona
2 participants
@sebastian-peter @staudtMarius