Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert groovy tests to ScalaTest, remove groovy #646

Closed
sebastian-peter opened this issue Nov 7, 2023 Discussed in #645 · 5 comments · Fixed by #773, #831, #832, #839 or #840
Closed

Convert groovy tests to ScalaTest, remove groovy #646

sebastian-peter opened this issue Nov 7, 2023 Discussed in #645 · 5 comments · Fixed by #773, #831, #832, #839 or #840
Assignees
@pierrepetersmeier
Labels
code quality Code readability or efficiency is improved test Issues related to (unit) tests
Milestone
Version 4.0

Comments

@sebastian-peter
Copy link
Member

Convert all groovy tests to ScalaTest, then remove everything related to groovy:

  • dependencies (spock, ...)
  • compile steps, if applicable
  • code formatting (spotlessGroovy)
  • ...
@sebastian-peter sebastian-peter added test Issues related to (unit) tests code quality Code readability or efficiency is improved labels Nov 7, 2023
@danielfeismann danielfeismann added the good first issue Good for newcomers label Nov 7, 2023
@SimonHuette SimonHuette mentioned this issue Feb 7, 2024
Merged
sebastian-peter added a commit that referenced this issue Feb 9, 2024
@sebastian-peter
Merge branch 'dev' into sh/#646-rewrite-groovy-test-to-scala-test
a46d189
danielfeismann added a commit that referenced this issue Feb 20, 2024
@danielfeismann
Merge branch 'dev' into sh/#646-rewrite-groovy-test-to-scala-test
d28bb0a
SimonHuette added a commit that referenced this issue Mar 5, 2024
@SimonHuette
Merge branch 'dev' into sh/#646-rewrite-groovy-test-to-scala-test
45b3528
@pierrepetersmeier pierrepetersmeier mentioned this issue Mar 18, 2024
Merged
@pierrepetersmeier pierrepetersmeier linked a pull request Mar 18, 2024 that will close this issue
pp/#646-convert-groovy-tests-to-scalatest #773
Merged
pierrepetersmeier added a commit that referenced this issue Mar 18, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-convert-groovy-tests-to-scalatest
65947e8
pierrepetersmeier added a commit that referenced this issue Mar 21, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-convert-groovy-tests-to-scalatest
fbdacfe
danielfeismann added a commit that referenced this issue Mar 25, 2024
@danielfeismann
Merge branch 'dev' into sh/#646-rewrite-groovy-test-to-scala-test
37f8d8c
danielfeismann added a commit that referenced this issue Apr 2, 2024
@danielfeismann
Merge branch 'dev' into sh/#646-rewrite-groovy-test-to-scala-test
b92ccf0
danielfeismann added a commit that referenced this issue Apr 15, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into sh/#646-rewrite-groovy-test-to-sca…
a64f9ea 
…la-test

# Conflicts:
#	CHANGELOG.md
danielfeismann added a commit that referenced this issue Apr 15, 2024
@danielfeismann
Merge pull request #726 from ie3-institute/sh/#646-rewrite-groovy-tes…
68bcf46 
…t-to-scala-test

Sh/#646 rewrite groovy test to scala test
danielfeismann added a commit that referenced this issue May 31, 2024
@danielfeismann
Merge branch 'dev' into pp/#646-convert-groovy-tests-to-scalatest
74ad862
danielfeismann added a commit that referenced this issue Jun 12, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into pp/#646-convert-groovy-tests-to-sc…
1ad0a86 
…alatest
@pierrepetersmeier pierrepetersmeier mentioned this issue Jun 16, 2024
Merged
@pierrepetersmeier pierrepetersmeier linked a pull request Jun 16, 2024 that will close this issue
FixedLoadModelSpec.scala-convert-groovy-to-scala #831
Merged
@pierrepetersmeier pierrepetersmeier mentioned this issue Jun 17, 2024
Merged
@pierrepetersmeier pierrepetersmeier linked a pull request Jun 17, 2024 that will close this issue
FixedfeedModelSpec-convert-groovy-tests-to-scalatest #832
Merged
pierrepetersmeier added a commit that referenced this issue Jun 26, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-FixedFeedModelSpec.scala-convert-groo…
cccad44 
…vy-tests-to-scalatest
pierrepetersmeier added a commit that referenced this issue Jun 26, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-convert-groovy-tests-to-scalatest-Fix…
d8c9f02 
…edLoadModelTest
pierrepetersmeier added a commit that referenced this issue Jun 26, 2024
@pierrepetersmeier
Merge remote-tracking branch 'origin/pp/#646-FixedFeedModelSpec.scala…
dc764e0 
…-convert-groovy-tests-to-scalatest' into pp/#646-FixedFeedModelSpec.scala-convert-groovy-tests-to-scalatest

# Conflicts:
#	CHANGELOG.md
@pierrepetersmeier pierrepetersmeier mentioned this issue Jun 28, 2024
Merged
@pierrepetersmeier pierrepetersmeier linked a pull request Jun 28, 2024 that will close this issue
Rewrote RefSystemTest from groovy to scala. #839
Merged
danielfeismann added a commit that referenced this issue Jul 1, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into pp/#646-convert-groovy-tests-to-sc…
41b56da 
…alatest

# Conflicts:
#	CHANGELOG.md
@pierrepetersmeier pierrepetersmeier linked a pull request Jul 1, 2024 that will close this issue
Rewrote SystemComponentSpec from groovy to scala #840
Merged
pierrepetersmeier added a commit that referenced this issue Oct 14, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-CylindricalThermalStorageTest-convert…
e428652 
…-groovy-tests-to-scalatest-remove-groovy
pierrepetersmeier added a commit that referenced this issue Oct 14, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-convert-SystemParticipantTest-to-scal…
3333c2f 
…atest-remove-groovy
danielfeismann added a commit that referenced this issue Oct 14, 2024
@danielfeismann
Merge pull request #971 from ie3-institute/pp/#646-convert-SystemPart…
bbdd9a5 
…icipantTest-to-scalatest-remove-groovy

convert system participant test to scalatest remove groovy
pierrepetersmeier added a commit that referenced this issue Oct 14, 2024
@pierrepetersmeier
Merge branch 'dev' into PP/#646-convert-ChpModelTest-to-scalatest-rem…
491d80e 
…ove-groovy
danielfeismann added a commit that referenced this issue Oct 15, 2024
@danielfeismann
Merge pull request #996 from ie3-institute/PP/#646-convert-ChpModelTe…
12f4e11 
…st-to-scalatest-remove-groovy

convert chp model test to scalatest remove groovy
@pierrepetersmeier
Copy link
Contributor

Tests that are still open to conversion:

PvModelIT (could be reworked a bit, currently feels a bit "hacky")
StorageModelTest
CylindricalThermalStorageTest

pierrepetersmeier added a commit that referenced this issue Oct 16, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-CylindricalThermalStorageTest-convert…
cc606d9 
…-groovy-tests-to-scalatest-remove-groovy
pierrepetersmeier added a commit that referenced this issue Oct 17, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-CylindricalThermalStorageTest-convert…
4431b6e 
…-groovy-tests-to-scalatest-remove-groovy
danielfeismann added a commit that referenced this issue Oct 21, 2024
@danielfeismann
Merge pull request #990 from ie3-institute/pp/#646-CylindricalThermal…
cb34d17 
…StorageTest-convert-groovy-tests-to-scalatest-remove-groovy

cylindrical thermal storage test convert groovy tests to scalatest remove groovy
@pierrepetersmeier pierrepetersmeier mentioned this issue Oct 22, 2024
Merged
@pierrepetersmeier pierrepetersmeier linked a pull request Oct 22, 2024 that will close this issue
convert storagemodeltest to scalatest remove groovy #1005
Merged
pierrepetersmeier added a commit that referenced this issue Oct 22, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-convert-storagemodeltest-to-scalatest…
fe122ee 
…-remove-groovy
pierrepetersmeier added a commit that referenced this issue Nov 5, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#646-convert-storagemodeltest-to-scalatest…
4fee9bb 
…-remove-groovy
danielfeismann added a commit that referenced this issue Nov 7, 2024
@danielfeismann
Merge pull request #1005 from ie3-institute/pp/#646-convert-storagemo…
d83160c 
…deltest-to-scalatest-remove-groovy

convert storagemodeltest to scalatest remove groovy
@danielfeismann danielfeismann reopened this Nov 7, 2024
pierrepetersmeier added a commit that referenced this issue Jan 6, 2025
@pierrepetersmeier
Merge branch 'dev' into pp/#646-PvModelIT-convert-groovy-tests-to-sca…
857e4d7 
…latest
@pierrepetersmeier pierrepetersmeier mentioned this issue Jan 6, 2025
Merged
pierrepetersmeier added a commit that referenced this issue Jan 21, 2025
@pierrepetersmeier
Merge branch 'dev' into pp/#646-PvModelIT-convert-groovy-tests-to-sca…
a3f3e6e 
…latest
danielfeismann added a commit that referenced this issue Jan 28, 2025
@danielfeismann
Merge branch 'dev' into pp/#646-PvModelIT-convert-groovy-tests-to-sca…
fe93ce6 
…latest
pierrepetersmeier added a commit that referenced this issue Jan 28, 2025
@pierrepetersmeier
Merge branch 'dev' into pp/#646-PvModelIT-convert-groovy-tests-to-sca…
65d13fc 
…latest
pierrepetersmeier added a commit that referenced this issue Jan 28, 2025
@pierrepetersmeier
Merge remote-tracking branch 'origin/pp/#646-PvModelIT-convert-groovy…
95440dc 
…-tests-to-scalatest' into pp/#646-PvModelIT-convert-groovy-tests-to-scalatest
pierrepetersmeier added a commit that referenced this issue Jan 31, 2025
@pierrepetersmeier
Merge branch 'dev' into pp/#646-PvModelIT-convert-groovy-tests-to-sca…
4d0421e 
…latest
pierrepetersmeier added a commit that referenced this issue Jan 31, 2025
@pierrepetersmeier
Merge remote-tracking branch 'origin/pp/#646-PvModelIT-convert-groovy…
7a7a6e2 
…-tests-to-scalatest' into pp/#646-PvModelIT-convert-groovy-tests-to-scalatest
danielfeismann added a commit that referenced this issue Jan 31, 2025
@danielfeismann
Merge pull request #1089 from ie3-institute/pp/#646-PvModelIT-convert…
2035782 
…-groovy-tests-to-scalatest

pv model it convert groovy tests to scalatest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierrepetersmeier pierrepetersmeier

Labels
code quality Code readability or efficiency is improved test Issues related to (unit) tests
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging a pull request may close this issue.

pp/#646-convert-groovy-tests-to-scalatest ie3-institute/simona
FixedLoadModelSpec.scala-convert-groovy-to-scala ie3-institute/simona
FixedfeedModelSpec-convert-groovy-tests-to-scalatest ie3-institute/simona
Rewrote RefSystemTest from groovy to scala. ie3-institute/simona
Rewrote SystemComponentSpec from groovy to scala ie3-institute/simona
Rewrote ThermalHouseTest from groovy to scala ie3-institute/simona
bm model test convert groovy tests to scalatest remove groovy ie3-institute/simona
cylindrical thermal storage test convert groovy tests to scalatest remove groovy ie3-institute/simona
convert chp model test to scalatest remove groovy ie3-institute/simona
convert storagemodeltest to scalatest remove groovy ie3-institute/simona
4 participants
@sebastian-peter @danielfeismann @SimonHuette @pierrepetersmeier