Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminate SimonSim when reading initialization fails #210

Closed
sebastian-peter opened this issue Apr 25, 2022 · 1 comment · Fixed by #746
Closed

Terminate SimonSim when reading initialization fails #210

sebastian-peter opened this issue Apr 25, 2022 · 1 comment · Fixed by #746
Assignees
@sebastian-peter
Labels
bug Something isn't working

Comments

@sebastian-peter
Copy link
Member

sebastian-peter commented Apr 25, 2022 •
edited
Loading

Currently, e.g. on reading faulty grid input data, an exception is thrown within SimonaSim but the simulation is not terminated.

Okay, turns out the problem is within SimonaSim. There, all actors are created during creation of the object SimonaSim, i.e. when the object constructor is called. This means though that any exceptions thrown during initialization here are not properly handled by SIMONA and the program just keeps running.
@sebastian-peter sebastian-peter added the bug Something isn't working label Apr 25, 2022
@sebastian-peter sebastian-peter changed the title Termiante SIMONA when reading initialization fails Terminate SIMONA when reading initialization fails May 2, 2022
@sebastian-peter
Copy link
Member Author

Possibly connected to #76

@sebastian-peter sebastian-peter self-assigned this May 5, 2022
@sebastian-peter sebastian-peter mentioned this issue May 10, 2022
Closed
sebastian-peter added a commit that referenced this issue May 31, 2022
@sebastian-peter
Merge branch 'dev' into sp/#210-restructure-SimonaSim
a9f05c4 
# Conflicts:
#	src/main/scala/edu/ie3/simona/scheduler/SchedulerHelper.scala
#	src/main/scala/edu/ie3/simona/sim/SimonaSim.scala
sebastian-peter added a commit that referenced this issue Jun 9, 2022
@sebastian-peter
Merge branch 'dev' into sp/#210-restructure-SimonaSim
eafbf51
sebastian-peter added a commit that referenced this issue Jun 20, 2022
@sebastian-peter
Merge branch 'dev' into sp/#210-restructure-SimonaSim
4c3308a
sebastian-peter added a commit that referenced this issue Sep 21, 2022
@sebastian-peter
Merge branch 'dev' into sp/#210-restructure-SimonaSim
8e717f0 
# Conflicts:
#	build.gradle
#	src/main/scala/edu/ie3/simona/scheduler/SchedulerHelper.scala
#	src/main/scala/edu/ie3/simona/sim/setup/SimonaStandaloneSetup.scala
#	src/test/scala/edu/ie3/simona/scheduler/ExtendedSimSchedulerSpec.scala
@sebastian-peter sebastian-peter changed the title Terminate SIMONA when reading initialization fails Terminate SimonSim when reading initialization fails Dec 7, 2022
sebastian-peter added a commit that referenced this issue Feb 21, 2024
@sebastian-peter
Merge branch 'dev' into sp/#210-simonasim-typed
d61fa97 
# Conflicts:
#	src/main/scala/edu/ie3/simona/main/RunSimona.scala
@sebastian-peter sebastian-peter mentioned this issue Feb 21, 2024
Merged
sebastian-peter added a commit that referenced this issue Feb 21, 2024
@sebastian-peter
Merge branch 'dev' into sp/#210-simonasim-typed
4e98f77
danielfeismann added a commit that referenced this issue Feb 23, 2024
@danielfeismann
Merge pull request #746 from ie3-institute/sp/#210-simonasim-typed
eef9c8f 
Convertig `SimonaSim` to a typed actor, improving failure handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastian-peter sebastian-peter

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@sebastian-peter