Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor WeatherSource and WeatherSourceWrapper #180

Closed
sebastian-peter opened this issue Mar 22, 2022 · 0 comments · Fixed by #724
Closed

Refactor WeatherSource and WeatherSourceWrapper #180

sebastian-peter opened this issue Mar 22, 2022 · 0 comments · Fixed by #724
Assignees
@staudtMarius
Labels
code quality Code readability or efficiency is improved

Comments

@sebastian-peter
Copy link
Member

WeatherSource:

  • WeatherSource#apply and WeatherSource#checkConfig can be consolidated. checkConfig is a bad name considering what the method is doing, anyway.
  • Creation of WeatherSourceWrapper in line 344ff can be simplified

WeatherSourceWrapper:

  • The usage of implicits in all WeatherSourceWrapper#apply methods is unnecessary and confusing

There's probably more once one looks deeper into this
@sebastian-peter sebastian-peter added good first issue Good for newcomers code quality Code readability or efficiency is improved labels Mar 22, 2022
@sebastian-peter sebastian-peter mentioned this issue Mar 22, 2022
Merged
@sebastian-peter sebastian-peter removed the good first issue Good for newcomers label Dec 13, 2023
@staudtMarius staudtMarius self-assigned this Feb 5, 2024
This was referenced Feb 5, 2024
Merged
Merged
staudtMarius added a commit that referenced this issue Mar 8, 2024
@staudtMarius
Merge branch 'dev' into ms/#180-refactor-WeatherSource-and-Wrapper
4f471d3 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/config/ConfigFailFast.scala
#	src/main/scala/edu/ie3/simona/service/weather/WeatherSource.scala
#	src/main/scala/edu/ie3/simona/service/weather/WeatherSourceWrapper.scala
#	src/test/scala/edu/ie3/simona/config/ConfigFailFastSpec.scala
#	src/test/scala/edu/ie3/simona/service/weather/WeatherSourceSpec.scala
staudtMarius added a commit that referenced this issue Apr 3, 2024
@staudtMarius
Merge branch 'dev' into ms/#180-refactor-WeatherSource-and-Wrapper
d85f2c0 
# Conflicts:
#	CHANGELOG.md
staudtMarius added a commit that referenced this issue May 7, 2024
@staudtMarius
Merge branch 'dev' into ms/#180-refactor-WeatherSource-and-Wrapper
965d5a0 
# Conflicts:
#	CHANGELOG.md
staudtMarius added a commit that referenced this issue May 16, 2024
@staudtMarius
Merge branch 'dev' into ms/#180-refactor-WeatherSource-and-Wrapper
7a08f35
staudtMarius added a commit that referenced this issue Jun 24, 2024
@staudtMarius
Merge branch 'refs/heads/dev' into ms/#180-refactor-WeatherSource-and…
ff15450 
…-Wrapper

# Conflicts:
#	src/main/scala/edu/ie3/simona/config/ConfigFailFast.scala
staudtMarius added a commit that referenced this issue Jul 1, 2024
@staudtMarius
Merge branch 'refs/heads/dev' into ms/#180-refactor-WeatherSource-and…
9f116eb 
…-Wrapper

# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/service/weather/SampleWeatherSource.scala
#	src/test/scala/edu/ie3/simona/service/weather/WeatherSourceSpec.scala
danielfeismann added a commit that referenced this issue Jul 3, 2024
@danielfeismann
Merge branch 'dev' into ms/#180-refactor-WeatherSource-and-Wrapper
eeac852
staudtMarius added a commit that referenced this issue Jul 8, 2024
@staudtMarius
Merge branch 'refs/heads/dev' into ms/#180-refactor-WeatherSource-and…
b6bb91d 
…-Wrapper

# Conflicts:
#	src/test/scala/edu/ie3/simona/config/ConfigFailFastSpec.scala
staudtMarius added a commit that referenced this issue Jul 9, 2024
@staudtMarius
Merge branch 'dev' into ms/#180-refactor-WeatherSource-and-Wrapper
fdef525
danielfeismann added a commit that referenced this issue Jul 11, 2024
@danielfeismann
Merge pull request #724 from ie3-institute/ms/#180-refactor-WeatherSo…
b714917 
…urce-and-Wrapper

Refactor WeatherSource and WeatherSourceWrapper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staudtMarius staudtMarius

Labels
code quality Code readability or efficiency is improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor WeatherSource and WeatherSourceWrapper. ie3-institute/simona
3 participants
@sebastian-peter @vickybung1 @staudtMarius