Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of states in ParticipantModelShell #1228

Closed
sebastian-peter opened this issue Feb 24, 2025 · 0 comments · Fixed by #1232
Closed

Fix handling of states in ParticipantModelShell #1228

sebastian-peter opened this issue Feb 24, 2025 · 0 comments · Fixed by #1232
Assignees
Labels
bug Something isn't working

Comments

@sebastian-peter
Copy link
Member

The determination of the current state is not correct, currently:

val state = _state
.zip(_operatingPoint)
.flatMap { case (st, op) =>
Option.when(st.tick < tick) {
model.determineState(st, op, modelInput)
}
}
.getOrElse(model.initialState(modelInput))

If the state for the current tick has already been calculated, it is not returned, but the initial state.

Check if this can be tested.

@sebastian-peter sebastian-peter added the bug Something isn't working label Feb 24, 2025
@sebastian-peter sebastian-peter self-assigned this Feb 24, 2025
staudtMarius added a commit that referenced this issue Feb 26, 2025
…ipantModelShell

Fix handling of state in `ParticipantModel` and `ParticipantModelShell`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant