Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SimonaListener #1205

Closed
staudtMarius opened this issue Feb 19, 2025 · 3 comments · Fixed by #1211
Closed

Remove SimonaListener #1205

staudtMarius opened this issue Feb 19, 2025 · 3 comments · Fixed by #1211
Assignees
@staudtMarius
Labels
code quality Code readability or efficiency is improved

Comments

@staudtMarius
Copy link
Member

No description provided.

@staudtMarius staudtMarius added the pekko typed Conversions from akka classic to typed label Feb 19, 2025
@staudtMarius staudtMarius self-assigned this Feb 19, 2025
@sebastian-peter
Copy link
Member

sebastian-peter commented Feb 19, 2025 •
edited
Loading

Is SimonaListener still needed somewhere at all? I think we should have that discussion first before starting any work here...

@staudtMarius
Copy link
Member Author

There was never an implementation. This and the other related files are there to give the user the option of adding custom listeners.

@staudtMarius staudtMarius changed the title Convert SimonaListener to typed Remove SimonaListener Feb 19, 2025
@staudtMarius
Copy link
Member Author

Since we never used them, I will remove all associated files.

@staudtMarius staudtMarius added code quality Code readability or efficiency is improved and removed pekko typed Conversions from akka classic to typed labels Feb 20, 2025
@staudtMarius staudtMarius mentioned this issue Feb 20, 2025
Merged
staudtMarius added a commit that referenced this issue Feb 20, 2025
@staudtMarius
Merge branch 'dev' into ms/#1205-remove-SimonaListener
d23752f
danielfeismann added a commit that referenced this issue Feb 20, 2025
@danielfeismann
Merge pull request #1211 from ie3-institute/ms/#1205-remove-SimonaLis…
afdcc65 
…tener

Remove `SimonaListener` and related code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staudtMarius staudtMarius

Labels
code quality Code readability or efficiency is improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove SimonaListener and related code. ie3-institute/simona
2 participants
@sebastian-peter @staudtMarius