-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuring SQL sources and introducing TimeSeriesTypeSource #546
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Coverage quality gate fails in large parts because of deprecations. So, pls go ahead with reviews if you like |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/test/groovy/edu/ie3/datamodel/io/source/sql/SqlWeatherSourcePsdmIT.groovy
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## dev #546 +/- ##
============================================
- Coverage 77.66% 77.65% -0.01%
- Complexity 2134 2150 +16
============================================
Files 271 276 +5
Lines 8458 8518 +60
Branches 804 808 +4
============================================
+ Hits 6569 6615 +46
- Misses 1492 1509 +17
+ Partials 397 394 -3
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for tackling this!
src/main/java/edu/ie3/datamodel/io/factory/timeseries/TimeSeriesTypeFactory.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/naming/DatabaseNamingStrategy.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/csv/CsvTimeSeriesTypeSource.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/sql/SqlTimeSeriesTypeSource.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/sql/SqlTimeSeriesTypeSource.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/sql/SqlTimeSeriesTypeSource.java
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvTimeSeriesTypeSourceIT.groovy
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/source/sql/SqlTimeSeriesMappingSource.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But we have a little too much duplicated code for sonarqube's taste
Resolves #515 and #545