Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring SQL sources and introducing TimeSeriesTypeSource #546

Merged
merged 13 commits into from
Mar 16, 2022

Conversation

sebastian-peter
Copy link
Member

Resolves #515 and #545

@sebastian-peter sebastian-peter linked an issue Feb 24, 2022 that may be closed by this pull request
@sebastian-peter sebastian-peter marked this pull request as draft February 24, 2022 16:32
@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sebastian-peter sebastian-peter self-assigned this Feb 24, 2022
@sebastian-peter sebastian-peter marked this pull request as ready for review February 24, 2022 17:58
@sebastian-peter
Copy link
Member Author

Coverage quality gate fails in large parts because of deprecations. So, pls go ahead with reviews if you like

@sebastian-peter sebastian-peter requested a review from a team February 24, 2022 22:18
@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

# Conflicts:
#	src/test/groovy/edu/ie3/datamodel/io/source/sql/SqlWeatherSourcePsdmIT.groovy
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #546 (e2c1c5b) into dev (1e739b5) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head e2c1c5b differs from pull request most recent head a377704. Consider uploading reports for the commit a377704 to get more accurate results

@@             Coverage Diff              @@
##                dev     #546      +/-   ##
============================================
- Coverage     77.66%   77.65%   -0.01%     
- Complexity     2134     2150      +16     
============================================
  Files           271      276       +5     
  Lines          8458     8518      +60     
  Branches        804      808       +4     
============================================
+ Hits           6569     6615      +46     
- Misses         1492     1509      +17     
+ Partials        397      394       -3     
Impacted Files Coverage Δ
.../edu/ie3/datamodel/io/source/TimeSeriesSource.java 0.00% <0.00%> (-50.00%) ⬇️
...3/datamodel/io/source/sql/SqlTimeSeriesSource.java 62.90% <0.00%> (-16.17%) ⬇️
...odel/io/source/sql/SqlTimeSeriesMappingSource.java 80.00% <0.00%> (-10.00%) ⬇️
...s/input/connector/type/Transformer2WTypeInput.java 74.00% <0.00%> (-2.00%) ⬇️
...e3/datamodel/models/input/connector/LineInput.java 75.43% <0.00%> (-1.76%) ⬇️
.../ie3/datamodel/io/connectors/CsvFileConnector.java 68.67% <0.00%> (-1.03%) ⬇️
...odel/io/source/csv/CsvTimeSeriesMappingSource.java 91.66% <0.00%> (-0.65%) ⬇️
...edu/ie3/datamodel/io/source/sql/SqlDataSource.java 71.05% <0.00%> (-0.38%) ⬇️
...3/datamodel/io/source/csv/CsvTimeSeriesSource.java 73.80% <0.00%> (ø)
...del/models/input/system/type/StorageTypeInput.java 71.42% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1935566...a377704. Read the comment docs.

@sonarqubegithubprchecks

This comment has been minimized.

Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this!

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sebastian-peter sebastian-peter requested a review from t-ober March 15, 2022 18:14
Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But we have a little too much duplicated code for sonarqube's taste

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • No coverage informationNo coverage information (77.10% Estimated after merge)
  • 5 percent duplication3.15% Duplicated Code (0.60% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@sebastian-peter sebastian-peter merged commit a10a543 into dev Mar 16, 2022
@sebastian-peter sebastian-peter deleted the sp/#515-restructure-sql-sources branch March 16, 2022 13:44
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify SQL time series tables of same type. More efficient timeseries sql source structure
2 participants