Introducing SqlIndividualTimeSeriesMetaInformation & refactorings 2.0

[sebastian-peter]

Resolves #513

Additions:

• SqlIndividualTimeSeriesMetaInformation analogous to CsvIndividualTimeSeriesMetaInformation

Adapted:

• SqlTimeSeriesSource
• SqlTimeSeriesMappingSource
• Tests

Refactorings (old classes deprecated):

• Moved from edu.ie3.datamodel.io.csv to edu.ie3.datamodel.io.naming: FileNameMetaInformation (renamed to TimeSeriesMetaInformation)
• Moved from edu.ie3.datamodel.io.csv.timeseries to edu.ie3.datamodel.io.naming.timeseries: IndividualTimeSeriesMetaInformation, LoadProfileTimeSeriesMetaInformation, ColumnScheme
• Moved from edu.ie3.datamodel.io.connectors.CsvFileConnector (static inner class) to edu.ie3.datamodel.io.csv: CsvIndividualTimeSeriesMetaInformation

[ckittl]

!test

[ckittl]

Thanks for this comprehensive work! I only have a few minor remarks.

[ckittl]

Please consider to expand the hidden conversations. Some are relevant, that are hidden.

[sonarqubegithubprchecks]

Analysis Details

10 Issues

• 0 Bugs
• 0 Vulnerabilities
• 10 Code Smells

Coverage and Duplications

• No coverage information (76.60% Estimated after merge)
• 4.96% Duplicated Code (0.40% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

[codecov]

Codecov Report

Merging #524 (b7900ec) into dev (2fbb010) will decrease coverage by 1.28%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #524      +/-   ##
============================================
- Coverage     78.93%   77.64%   -1.29%     
- Complexity     2129     2135       +6     
============================================
  Files           265      271       +6     
  Lines          8356     8505     +149     
  Branches        785      806      +21     
============================================
+ Hits           6596     6604       +8     
- Misses         1359     1501     +142     
+ Partials        401      400       -1     

Impacted Files	Coverage Δ
.../ie3/datamodel/io/csv/timeseries/ColumnScheme.java	0.00% <0.00%> (-100.00%)	⬇️
.../ie3/datamodel/io/csv/FileNameMetaInformation.java	0.00% <0.00%> (-66.67%)	⬇️
.../edu/ie3/datamodel/io/source/TimeSeriesSource.java	50.00% <0.00%> (-50.00%)	⬇️
...imeseries/IndividualTimeSeriesMetaInformation.java	0.00% <0.00%> (-50.00%)	⬇️
...meseries/LoadProfileTimeSeriesMetaInformation.java	0.00% <0.00%> (-33.34%)	⬇️
...3/datamodel/io/source/csv/CsvTimeSeriesSource.java	73.80% <0.00%> (-20.13%)	⬇️
...3/datamodel/io/source/sql/SqlTimeSeriesSource.java	79.06% <0.00%> (-12.60%)	⬇️
...du/ie3/datamodel/io/naming/FileNamingStrategy.java	81.25% <0.00%> (-11.61%)	⬇️
...del/io/naming/EntityPersistenceNamingStrategy.java	83.58% <0.00%> (-10.54%)	⬇️
...odel/io/source/sql/SqlTimeSeriesMappingSource.java	90.00% <0.00%> (-10.00%)	⬇️
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21d301...b7900ec. Read the comment docs.