Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeSeriesSource: get activation ticks #543

Closed
sebastian-peter opened this issue Feb 23, 2022 · 1 comment · Fixed by #1059
Closed

TimeSeriesSource: get activation ticks #543

sebastian-peter opened this issue Feb 23, 2022 · 1 comment · Fixed by #1059
Assignees
@staudtMarius
Labels
enhancement New feature or request

Comments

@sebastian-peter
Copy link
Member

sebastian-peter commented Feb 23, 2022 •
edited
Loading

As discussed in ie3-institute/simona#98 (comment), the interface and corresponding implementations of edu.ie3.datamodel.io.source.TimeSeriesSource should be enhanced with a method that returns all activation ticks for a time series (after a given time):

List<ZonedDateTime> getTimeKeysAfter(ZonedDateTime time);

This way, the implementations can take into account efficient methods for each data source type (e.g. with SQL this can be solved with a simple and quick query).
@sebastian-peter sebastian-peter added the code quality Code readability or structure is improved label Feb 23, 2022
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 23, 2022
@sebastian-peter sebastian-peter self-assigned this Feb 23, 2022
@sebastian-peter sebastian-peter changed the title TimeSeriesSource: get first time after given time TimeSeriesSource: get first time after given time Feb 23, 2022
@sebastian-peter sebastian-peter mentioned this issue Feb 23, 2022
Merged
@sebastian-peter sebastian-peter changed the title TimeSeriesSource: get first time after given time TimeSeriesSource: get activation ticks Feb 24, 2022
@sebastian-peter
Copy link
Member Author

Possibly a duplicate of #506

This was referenced Apr 5, 2022
Closed
Closed
@sebastian-peter sebastian-peter removed the code quality Code readability or structure is improved label Jul 28, 2022
@sebastian-peter sebastian-peter removed this from the Version 4.0 milestone Jul 25, 2023
@sebastian-peter sebastian-peter removed their assignment Feb 1, 2024
@staudtMarius staudtMarius self-assigned this Apr 8, 2024
@staudtMarius staudtMarius mentioned this issue Apr 8, 2024
Merged
staudtMarius added a commit that referenced this issue Apr 9, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
27197fd 
…-activation-call
staudtMarius added a commit that referenced this issue Apr 9, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
4785c51 
…-activation-call
@staudtMarius staudtMarius added the enhancement New feature or request label Apr 9, 2024
staudtMarius added a commit that referenced this issue Apr 15, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
3e7d708 
…-activation-call

# Conflicts:
#	CHANGELOG.md
staudtMarius added a commit that referenced this issue Apr 23, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
2bc514b 
…-activation-call
staudtMarius added a commit that referenced this issue Apr 30, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
54d2498 
…-activation-call
staudtMarius added a commit that referenced this issue May 1, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
945793d 
…-activation-call

# Conflicts:
#	CHANGELOG.md
staudtMarius added a commit that referenced this issue May 6, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
db990d2 
…-activation-call
staudtMarius added a commit that referenced this issue May 7, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
afcac35 
…-activation-call
staudtMarius added a commit that referenced this issue May 16, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
50da7db 
…-activation-call
staudtMarius added a commit that referenced this issue May 23, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
2d48c86 
…-activation-call

# Conflicts:
#	CHANGELOG.md
staudtMarius added a commit that referenced this issue Jun 4, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
8bab275 
…-activation-call
staudtMarius added a commit that referenced this issue Jun 10, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
cd8f83c 
…-activation-call

# Conflicts:
#	CHANGELOG.md
staudtMarius added a commit that referenced this issue Jun 11, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
4ff3810 
…-activation-call
staudtMarius added a commit that referenced this issue Jun 11, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
cdaf952 
…-activation-call
staudtMarius added a commit that referenced this issue Jun 24, 2024
@staudtMarius
Merge branch 'refs/heads/dev' into ms/#543-enhance-timeseriesSources-…
909db48 
…with-future-activation-call

# Conflicts:
#	CHANGELOG.md
staudtMarius added a commit that referenced this issue Jun 24, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
b4a1a29 
…-activation-call
staudtMarius added a commit that referenced this issue Jun 24, 2024
@staudtMarius
Merge branch 'refs/heads/dev' into ms/#543-enhance-timeseriesSources-…
56280ab 
…with-future-activation-call

# Conflicts:
#	src/main/java/edu/ie3/datamodel/io/source/csv/CsvWeatherSource.java
staudtMarius added a commit that referenced this issue Jun 24, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
b63ae06 
…-activation-call
staudtMarius added a commit that referenced this issue Jul 1, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
6862fbb 
…-activation-call
staudtMarius added a commit that referenced this issue Jul 4, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
efb7fff 
…-activation-call
staudtMarius added a commit that referenced this issue Jul 9, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
a8fe02d 
…-activation-call
staudtMarius added a commit that referenced this issue Jul 29, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
8dc7b0e 
…-activation-call
staudtMarius added a commit that referenced this issue Aug 9, 2024
@staudtMarius
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
be66f2b 
…-activation-call
sebastian-peter added a commit that referenced this issue Aug 22, 2024
@sebastian-peter
Merge branch 'dev' into ms/#543-enhance-timeseriesSources-with-future…
75e10a9 
…-activation-call
sebastian-peter added a commit that referenced this issue Aug 22, 2024
@sebastian-peter
Merge pull request #1059 from ie3-institute/ms/#543-enhance-timeserie…
0fa4219 
…sSources-with-future-activation-call

Enhancing `TimeSeriesSource`s with method to extract future activation ticks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staudtMarius staudtMarius

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@sebastian-peter @staudtMarius