Add 'instance UniformRange Natural' #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main addition here is to add
instance UniformRange Natural
, also see haskell#44.To do this, I changed the
Integer
-specificuniformIntegerM
to a genericuniformIntegralM
. Since this function was and is recursive, I changed the pragma fromINLINE
toINLINEABLE
.I made sure that these more generic functions are no slower than before. Note that
random/Integer
benchmarks small ranges, for which a fast path is triggered;uniformR/unbounded/Integer
and the newuniformR/unbounded/Natural
benchmark very large ranges where there is no fast path.Before (9ee79a7):
After (this PR):
Other changes:
uniformR
instead ofrandomR
; this allow us to make the constraints more preciseNatural
benchmark and specs