Hex conv tf2 #16
Merged
Hex conv tf2 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hexagonal convolution kernels could not properly propagate gradients through to their kernel weights because these weights were modfied (via
tf.stack/tf.concat) prior to the forward pass of the layer. As a result,GradientTapewas not able to find any gradients for the kernel weights. This PR introduces separate classes for the hexagonal kernel creation that seperates out weight initialization to the class's constructor and any transformations to the forward pass in__call__.Additionally, names for created weights are now fully propagated through.