feat(ppnlb): Add support for Reserved IP as member target of PPNLB #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keerthi-gp
changed the title
keerthi-gp
force-pushed
the
UI-40655-PPNLB-Reserved-IP
branch
from
211c2fc to
1d9cd1c
Compare
uibm
reviewed
Jan 31, 2025
| @@ -92,10 +92,11 @@ if [ "${TF_DEV}x" = "x" ]; then | |||
| echo "==> Packaging..." | |||
| for PLATFORM in $(find ./pkg -mindepth 1 -maxdepth 1 -type d); do | |||
| OSARCH=$(basename ${PLATFORM}) | |||
| ZIPNAME="terraform-provider-ibm_${VERSION}_${OSARCH}" | |||
There was a problem hiding this comment.
same, this file needs to be restored to master. This is just change to have the version in the binary generated
There was a problem hiding this comment.
revert this change
SunithaGudisagarIBM1
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
As mentioned #414 doc needs to be changed in alphanumaric format and also attach the test results in the PR..
make testacc TEST=./ibm/service/vpc TESTARGS='-run='
to run acceptance test and also attach the results in the PR
Also Upload Binary to Artifactory and inform CSI team once you have tested in staging env
https://github.com/ibm-vpc/terraform-provider-ibm/wiki/Upload-Binary-to-Artifactory
Otherwise PR looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.