Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array format support is not reflected in the type definition for typescript #944

Closed
crhg opened this issue Jun 30, 2020 · 4 comments · Fixed by #945
Closed

Array format support is not reflected in the type definition for typescript #944

crhg opened this issue Jun 30, 2020 · 4 comments · Fixed by #945
Labels
released

Comments

@crhg
Copy link

crhg commented Jun 30, 2020

Describe the bug
Array format is supported by #906, but typescript gives the following type error.

dayjs('2020-02-02', ['YYYY', 'YYYY-DD-MM'])
 error TS2345: Argument of type 'string[]' is not assignable to parameter of type 'string | { locale?: string | undefined; format?: string | undefined; utc?: boolean | undefined; } | undefined'.
      Type 'string[]' is not assignable to type 'string'.

I think we need to update the function signature for typescript.

Expected behavior
It works just as well as javascript

Information

  • Day.js Version : 1.8.28
  • OS: macOS
iamkun added a commit that referenced this issue Jun 30, 2020
@iamkun
fix: Update type definition to support array format
4a04402 
fix #944
@iamkun iamkun mentioned this issue Jun 30, 2020
Merged
@iamkun
Copy link
Owner

iamkun commented Jun 30, 2020

Updated, thanks.

iamkun added a commit that referenced this issue Jun 30, 2020
@iamkun
fix: Update type definition to support array format (#945)
81d4740 
fix #944
iamkun pushed a commit that referenced this issue Jul 2, 2020
@semantic-release-bot
chore(release): 1.8.29 [skip ci]
f236aef 
## [1.8.29](v1.8.28...v1.8.29) (2020-07-02)

### Bug Fixes

* Duration plugin supports parse ISO string with week (W) ([#950](#950)) ([f0fc12a](f0fc12a))
* LocaleData plugin supports locale order ([#938](#938)) ([62f429d](62f429d)), closes [#936](#936)
* Update type definition to support array format ([#945](#945)) ([81d4740](81d4740)), closes [#944](#944)
* Update type definition to support strict mode ([#951](#951)) ([8d54f3f](8d54f3f))
@iamkun
Copy link
Owner

iamkun commented Jul 2, 2020

🎉 This issue has been resolved in version 1.8.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Jul 2, 2020
@sziraqui
Copy link

sziraqui commented Oct 8, 2020

Same issue on dayjs.utc()

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.29 [skip ci]
3615770 
## [1.8.29](iamkun/dayjs@v1.8.28...v1.8.29) (2020-07-02)

### Bug Fixes

* Duration plugin supports parse ISO string with week (W) ([#950](iamkun/dayjs#950)) ([f0fc12a](iamkun/dayjs@f0fc12a))
* LocaleData plugin supports locale order ([#938](iamkun/dayjs#938)) ([62f429d](iamkun/dayjs@62f429d)), closes [#936](iamkun/dayjs#936)
* Update type definition to support array format ([#945](iamkun/dayjs#945)) ([81d4740](iamkun/dayjs@81d4740)), closes [#944](iamkun/dayjs#944)
* Update type definition to support strict mode ([#951](iamkun/dayjs#951)) ([8d54f3f](iamkun/dayjs@8d54f3f))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.29 [skip ci]
871ce85 
## [1.8.29](iamkun/dayjs@v1.8.28...v1.8.29) (2020-07-02)

### Bug Fixes

* Duration plugin supports parse ISO string with week (W) ([#950](iamkun/dayjs#950)) ([f0fc12a](iamkun/dayjs@f0fc12a))
* LocaleData plugin supports locale order ([#938](iamkun/dayjs#938)) ([62f429d](iamkun/dayjs@62f429d)), closes [#936](iamkun/dayjs#936)
* Update type definition to support array format ([#945](iamkun/dayjs#945)) ([81d4740](iamkun/dayjs@81d4740)), closes [#944](iamkun/dayjs#944)
* Update type definition to support strict mode ([#951](iamkun/dayjs#951)) ([8d54f3f](iamkun/dayjs@8d54f3f))
@RaymondMwaura
Copy link

Still unresolved:

dayjs(dataItem[dateField], "DD-MM-YYYY");

splashwizard pushed a commit to splashwizard/tracking-time that referenced this issue Oct 21, 2024
@semantic-release-bot
chore(release): 1.8.29 [skip ci]
8f43790 
## [1.8.29](iamkun/dayjs@v1.8.28...v1.8.29) (2020-07-02)

### Bug Fixes

* Duration plugin supports parse ISO string with week (W) ([#950](iamkun/dayjs#950)) ([f0fc12a](iamkun/dayjs@f0fc12a))
* LocaleData plugin supports locale order ([#938](iamkun/dayjs#938)) ([62f429d](iamkun/dayjs@62f429d)), closes [#936](iamkun/dayjs#936)
* Update type definition to support array format ([#945](iamkun/dayjs#945)) ([81d4740](iamkun/dayjs@81d4740)), closes [#944](iamkun/dayjs#944)
* Update type definition to support strict mode ([#951](iamkun/dayjs#951)) ([8d54f3f](iamkun/dayjs@8d54f3f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Update type definition to support array format iamkun/dayjs
4 participants
@crhg @sziraqui @RaymondMwaura @iamkun