Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localizedFormat plugin is interpolating content inside square brackets #550

Closed
mariomc opened this issue Mar 29, 2019 · 3 comments
Closed

Comments

@mariomc
Copy link
Contributor

mariomc commented Mar 29, 2019

Describe the bug
localizedFormat plugin is changing/interpolating content inside square brackets

const dayJSformat = dayjs.format('[L]') // outputs: 29/03/2019
const momentFormat = moment.format('[L]') // outputs [L]
expect(dayJSformat).toEqual(momentFormat) // throws

Expected behavior
localizedFormat plugin should uphold behavior of the original format method and not change/interpolate content inside square brackets

Information

  • Day.js Version: all
  • OS: all
  • Browser: all
@mariomc
Copy link
Contributor Author

mariomc commented Mar 29, 2019

If you want, i'll include this fix inside #546

@ghost
Copy link

ghost commented Mar 29, 2019

Sounds good

mariomc added a commit to mariomc/dayjs that referenced this issue Mar 29, 2019
@iamkun
Copy link
Owner

iamkun commented Apr 2, 2019

#546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants