fix: page object parameters type and default xpath root

iamkenos · Apr 7, 2024 · c49e551 · c49e551
1 parent ad21b29
commit c49e551
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/core/page-object.ts b/src/core/page-object.ts
@@ -7,7 +7,7 @@ export abstract class PageObject<ParametersType = WorldParameters> {
   protected readonly logger: World["logger"];
   protected readonly context: BrowserContext;
   protected page: Page;
-  protected parameters: ParametersType | WorldParameters;
+  protected parameters: ParametersType;
   abstract url: string;
   abstract title: string;
 
@@ -16,7 +16,7 @@ export abstract class PageObject<ParametersType = WorldParameters> {
     this.logger = world.logger;
     this.context = world.context;
     this.page = world.page;
-    this.parameters = world.parameters;
+    this.parameters = world.parameters as any;
   }
 
   async navigate() {

diff --git a/src/core/utils/xpath-builder.ts b/src/core/utils/xpath-builder.ts
@@ -9,7 +9,7 @@ export class XPathBuilder {
 
   constructor(selector?: string) {
     this.conditionals = [];
-    this.selector = selector || `//${this.ANY}`;
+    this.selector = selector || `//self::${this.ANY}`;
   }
 
   private wrap(condition: string, not = false) {
@@ -246,6 +246,11 @@ export class XPathBuilder {
     return this;
   }
 
+  self(tag = this.ANY) {
+    this.conditionals.push(`/self::${this.unslash(tag)}`);
+    return this;
+  }
+
   build(index?: number | string) {
     const selector = this.selector + this.conditionals.join("");
     return this.index(selector, index as any);