refactor: use typed globalThis

.eslintrc

@@ -3,11 +3,11 @@
   "plugins": ["@typescript-eslint"],
   "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
   "rules": {
-    "@typescript-eslint/ban-ts-comment": ["off"],
-    "@typescript-eslint/ban-types": ["off"],
-    "@typescript-eslint/no-empty-function": ["off"],
-    "@typescript-eslint/no-explicit-any": ["off"],
-    "@typescript-eslint/no-var-requires": ["off"],
+    "@typescript-eslint/ban-ts-comment": ["off", {}],
+    "@typescript-eslint/ban-types": ["off", {}],
+    "@typescript-eslint/no-empty-function": ["off", {}],
+    "@typescript-eslint/no-explicit-any": ["off", {}],
+    "@typescript-eslint/no-var-requires": ["off", {}],
     "indent": [
       "error",
       2,
@@ -45,10 +45,16 @@
     {
       "files": ["*.js"],
       "rules": {
-        "@typescript-eslint/no-unused-vars": ["off"],
+        "@typescript-eslint/no-unused-vars": ["off", {}],
         "quotes": ["error", "single"],
         "no-undef": ["off"]
       }
+    },
+    {
+      "files": ["types.ts"],
+      "rules": {
+        "no-var": ["off"]
+      }
     }
   ]
 }

demo/test/fixtures/pages/demo/demo.def.ts

@@ -7,7 +7,7 @@ export interface This extends World {
 }
 
 Before({}, async function(this: This) {
-  this.demoPage = new DemoPage(this);
+  this.demoPage = new DemoPage();
 });
 
 When(

src/cli/resources/fixtures/pages/the-internet.def.ts

@@ -27,10 +27,10 @@ export interface This extends World<Parameters> {
 }
 
 Before({}, async function(this: This) {
-  this.theInternetPage = new TheInternetPage(this);
-  this.exitIntentPage = new ExitIntentPage(this);
-  this.loginPage = new LoginPage(this);
-  this.securePage = new SecurePage(this);
+  this.theInternetPage = new TheInternetPage();
+  this.exitIntentPage = new ExitIntentPage();
+  this.loginPage = new LoginPage();
+  this.securePage = new SecurePage();
 });
 
 When(

src/commands/context/types.ts

@@ -2,7 +2,6 @@ import type { BrowserContext as PlaywrightBrowserContextType } from "@playwright
 import type { Page } from "@commands/page/types";
 import type { Locator } from "@commands/locator/types";
 import type { Config } from "@config/types";
-import type { World } from "@core/world";
 import type { BrowserContext as BrowserContextClassType } from "./context";
 import type { closeLastPage } from "./command/close-last-page";
 import type { closeOtherPages } from "./command/close-other-pages";
@@ -12,7 +11,6 @@ import type { newPage } from "./command/new-page";
 export interface BrowserContext extends PlaywrightBrowserContextType, BrowserContextClassType {
   config: Config;
   locatorSearchLimit: Locator;
-  reporter: World["reporter"];
   closeLastPage: typeof closeLastPage;
   closeOtherPages: typeof closeOtherPages;
   lastPage: typeof lastPage;

src/conditions/page/condition/snapshot-match.ts

@@ -31,7 +31,7 @@ export class SnapshotMatch extends PageCondition {
     const { outDir } = this.page.context().config.snapshots.images;
     const attach = (title: string, filename: string) => {
       if (fs.existsSync(filename)) {
-        this.page.context().reporter.step(title, (step: AllureCommandStepExecutable) => step.attach(fs.readFileSync(filename), "image/png"));
+        _kyk_world.reporter.step(title, (step: AllureCommandStepExecutable) => step.attach(fs.readFileSync(filename), "image/png"));
       }
     };
 

src/config/index.ts

@@ -39,7 +39,7 @@ export function configure(overrides?: Partial<Config>) {
     }
   };
   // resolve and prepare snapshot directories
-  process.env.KYK_RESULTS = resultsDir;
+  globalThis._kyk_allure_results_dir = resultsDir;
   process.env.LOG_LEVEL = debug ? "debug" : logLevel;
   fs.removeSync(resultsDir);
   Object.keys(snapshots).forEach(key => {

src/core/page-object.ts

@@ -11,12 +11,12 @@ export abstract class PageObject<ParametersType = WorldParameters> {
   abstract url: string;
   abstract title: string;
 
-  constructor(world: World) {
-    this.reporter = world.reporter;
-    this.logger = world.logger;
-    this.context = world.context;
-    this.page = world.page;
-    this.parameters = world.parameters as any;
+  constructor() {
+    this.reporter = _kyk_world.reporter;
+    this.logger = _kyk_world.logger;
+    this.context = _kyk_world.context;
+    this.page = _kyk_world.page;
+    this.parameters = _kyk_world.parameters as any;
   }
 
   async navigate() {

src/core/types.ts

@@ -0,0 +1,6 @@
+import type { This as World } from "./world";
+
+declare global {
+  var _kyk_allure_results_dir: string;
+  var _kyk_world: World;
+}

src/core/utils/reporter.ts

@@ -6,6 +6,6 @@ import { CucumberJSAllureFormatter } from "allure-cucumberjs";
 /** see https://github.com/allure-framework/allure-js/blob/master/packages/allure-cucumberjs/README.md */
 export default class extends CucumberJSAllureFormatter {
   constructor(options: any) {
-    super(options, new AllureRuntime({ resultsDir: path.join(process.env.KYK_RESULTS, "allure") }), {});
+    super(options, new AllureRuntime({ resultsDir: path.join(_kyk_allure_results_dir, "allure") }), {});
   }
 }

src/core/world.ts

@@ -53,6 +53,7 @@ export abstract class World extends AllureWorld implements PrivateWorld {
     this.setPageObjects();
     this.setReporter();
     this.loadCommands();
+    globalThis._kyk_world = this;
   }
 
   private setPageObjects() {
@@ -122,7 +123,6 @@ export abstract class World extends AllureWorld implements PrivateWorld {
     const from = await browser.newContext(this.config.contextOptions);
     const context = new BrowserContextClass(from) as BrowserContext;
     context.setDefaultTimeout(this.config.timeout);
-    context.reporter = this.reporter;
     context.config = this.config;
     return context;
   }