Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorDef validation and ColorByName fix (bp #3360) #3438

Merged
merged 5 commits into from
Mar 29, 2022

Conversation

pmconne
Copy link
Member

@pmconne pmconne commented Mar 29, 2022

Cherry-picked from #3360.

pmconne added 5 commits March 29, 2022 11:53
* ColorByName is an object not an enum

Add ColorDef validation.

* Test ColorDef.getName

* docs, types.

* lint, extract-api

* NextVersion.md

* why aren't integration tests running?

* so much casting.

(cherry picked from commit 84290b9)
@pmconne pmconne enabled auto-merge (squash) March 29, 2022 18:31
@pmconne pmconne merged commit 8e77713 into release/2.19.x Mar 29, 2022
@pmconne pmconne deleted the bp/2.19.x/3360 branch March 29, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants