Improve OSD stats page avg efficiency value scaling #9109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TBH, I think this is more important for Imperial than for Metric. As a mile is a greater distance, so will always use more mAh. |
Yes, you totally got a point there! I have just added a commit with the same changes to the imperial units as well. However, since I don't use imperial units in any of my crafts, if someone else could test it and provide feedback whether it's displaying as it should, it would be great! |
|
Just a quick update. I have already flown this for two weekends with no major issues detected. |
|
Nice, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the value scaling of the AVG EFFICIENCY (mAh/km or similar) field in the OSD stats page (shown after craft disarming) when using BFCOMPAT modes.
The idea is that scaling to Ah/km only happens when the value is above 999mAh/km, and not when above 99mAh/km.
Only implemented for metric units, didn't change (nor test) for imperial units.