-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to BFCOMPAT character and icon mappings #8926
Conversation
Awesome. Thank you |
|
||
// GPS and navigation | ||
#define BF_SYM_LAT 0x89 | ||
#define BF_SYM_LON 0x98 | ||
#define BF_SYM_ALTITUDE 0x7F | ||
#define BF_SYM_TOTAL_DISTANCE 0x71 | ||
#define BF_SYM_TOTAL_DISTANCE 0x2A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug in DJI's font. I don't think we should change this.
In theory they are working with the BF team and may fix this.
I don't think we should deviate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested and they are working on my goggles. If DJI changes it, we change it as well, I don't see a problem here.
@@ -32,12 +32,14 @@ | |||
#define BF_SYM_ROLL 0x14 | |||
#define BF_SYM_PITCH 0x15 | |||
#define BF_SYM_TEMPERATURE 0x7A | |||
#define BF_SYM_MAX 0x24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These symbols don't exist in betaflight, so we should not add them here.
This file is based on betaflight/src/main/drivers/osd_symbols.h
Also, refer to https://betaflight.com/docs/development/osd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? These symbols work just fine for me, so what's the point of trying to exactly mirror Betaflight's behavior, can't we improve on it?
IMHO, we have messed about with the OSD code enough already for DJI. There is a lot of mess in there now because DJI doesn’t want to implement MSP DisplayPort properly and fully. |
Improve the character and icon mappings for BF compatible OSD modes, both BF43COMPAT and the upcoming BFHDCOMPAT mode.
This should reduce the number of "?" characters, by using more of the available icons provided by DJI or direct letter abbreviations.
Reference for the available characters: