Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set dummy attributes to same type (@null) #2439

Merged
merged 1 commit into from
Nov 28, 2020
Merged

fix: set dummy attributes to same type (@null) #2439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions brut.apktool/apktool-lib/src/main/java/brut/androlib/res/decoder/ARSCDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,9 +516,11 @@ private void addMissingResSpecs() throws AndrolibException {
mType = mPkg.getOrCreateConfig(new ResConfigFlags());
}

ResValue value = new ResBoolValue(false, 0, null);
ResResource res = new ResResource(mType, spec, value);
// We are going to make dummy attributes a null reference (@null) now instead of a boolean false.
// This is because aapt2 is much more strict when it comes to what we can put in an application.
ResValue value = new ResReferenceValue(mPkg, 0, "");

ResResource res = new ResResource(mType, spec, value);
mPkg.addResource(res);
mType.addResource(res);
spec.addResource(res);
Expand Down