fix #1299: add support for icu macro in typescript

[cellog]

Checklist

• only relevant code is changed (make a diff before you submit the PR)
• run tests npm run test
• tests are included
• documentation is changed or added

[coveralls]

Coverage remained the same at 96.222% when pulling 40dc40b on cellog:icu-types into da07fba on i18next:master.

[pedrodurek]

Everything inside the module will be exported (even without the export keyword), I don't think we have an i18n under react-i18next. If you don't want to re-export all these types, you should import them outside the module.

Suggested change

	declare module 'react-i18next/icu.macro' {
	type Namespace = import('.').Namespace;
	type DefaultNamespace = import('.').DefaultNamespace;
	type Resources = import('.').Resources;
	type TFuncKey<N extends Namespace = DefaultNamespace, T = Resources> = import('.').TFuncKey<N, T>;
	type i18n = import('i18next').i18n;
	import {Namespace, DefaultNamespace, Resources, TFuncKey, TransProps} from '.';
	import {i18n} from 'i18next';
	declare module 'react-i18next/icu.macro' {

[cellog]

when I did it this way, the types stopped working in VS Code, and it also failed to type them at all (they became any). Can you confirm?

[pedrodurek]

yeah, it works perfectly, but you also need to rename the file declaration to uci.macro.d.ts, otherwise, it won't find the module.

[cellog]

FYI, tslint is going nuts now. Should we be concerned? I'm going to push this as you recommend, and then we can decide this question.

[pedrodurek]

So you can add the export again if you want

[pedrodurek]

Here we can simply remove children

[cellog]

the intent here was to prevent children. In other words, typescript will error if you pass children in, as a way of signaling "children will be ignored"

[pedrodurek]

I believe this will happen for Select component only 🤔 , because you're intersecting its props with SelectSubProps

[cellog]

true, I'll add it to PluralProps to solve that oversight

[pedrodurek]

As I mentioned above all types inside the module will be exported so we don't need the export keyword

[pedrodurek]

You can re-export the Trans function, but it needs to be done outside the module.

Suggested change

	export function Trans<
	K extends TFuncKey<N> extends infer A ? A : never,
	N extends Namespace = DefaultNamespace,
	E extends Element = HTMLDivElement
	>(props: import('.').TransProps<K, N, E>): React.ReactElement;
	}
	}
	export { Trans };

[pedrodurek]

LGTM!!! 🎉 🙌

[cellog]

awesome! I'm going to put up the other PR idea in a draft PR. I will rebase it on master once this is merged, so I can add the typescript types for it too. Nice doing bidness wit you :)