Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript WithNamespacesOptions.wait must be optional #676

Closed
nikolay-borzov opened this issue Jan 15, 2019 · 0 comments
Closed

TypeScript WithNamespacesOptions.wait must be optional #676

nikolay-borzov opened this issue Jan 15, 2019 · 0 comments

Comments

@nikolay-borzov
Copy link
Contributor

Describe the bug
WithNamespacesOptions.wait is not marked as optional but docs say it has false as a default value

Occurs in react-i18next version
9.0.1

To Reproduce

function MyComponent() {
  return <span>Yeah!</span>
}

const translated = withNamespaces('', {})(MyComponent);
/*
[ts] Argument of type '{}' is not assignable to parameter of type 'WithNamespacesOptions'.
  Property 'wait' is missing in type '{}' but required in type 'WithNamespacesOptions'. [2345]
*/

Expected behaviour
It should be possible to set other withNamespaces options w/o explicitly setting wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants