Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vmapper:Z requires physical re-mapping and rewiring of panels when switching from odd to even number in height #1663

Closed
marcmerlin opened this issue Jun 11, 2024 · 2 comments

Comments

@marcmerlin
Copy link
Collaborator

You can currently wire things so that they work whether you have odd or even, but if you try to add a panel, everything gets flipped around
#1014 still works, but is fairly suboptimal

@marcmerlin
Copy link
Collaborator Author

marcmerlin commented Jun 11, 2024

This is with --led-chain=4
PXL_20240611_154150807

and with --led-chain=5, everything is reversed and all the panels need to be re-wired for the new order.
PXL_20240611_154215361

As per my upcoming PR, the problem and solution

+    // because the panel you plug into ends up being the "bottom" panel and coordinates
+    // start from the top panel, and you typically don't wire the bottom panel (first in
+    // the chain) upside down, whether each panel gets swapped depends on this.
+    // Without this, if you wire for 4 panels high and add a 5h panel, without this
+    // code everything would get reversed and you'd have to re-layout all the panels
+    bool is_height_even_panels = ( matrix_width / panel_width) % 2;

@marcmerlin
Copy link
Collaborator Author

this is now fixed in #1664

hzeller added a commit that referenced this issue Jul 29, 2024
Fix for orientation being swapped as described in #1663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant