Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc and import improvement #2 #59

Merged
merged 9 commits into from
Nov 12, 2022
Merged

Doc and import improvement #2 #59

merged 9 commits into from
Nov 12, 2022

Conversation

jlaehne
Copy link
Member

@jlaehne jlaehne commented Nov 5, 2022

Description of the change

Follow up on #47, adresses #38. Starting to continue working on the readers (from the back of the alphabet).

Progress of the PR

  • Change implemented (can be split into several points),
  • update docstring (if appropriate),
  • update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • add tests,
  • ready for review.

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 83.39% // Head: 83.47% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (c3d8b1f) compared to base (1fe89dd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   83.39%   83.47%   +0.07%     
==========================================
  Files          43       49       +6     
  Lines        8348     8388      +40     
  Branches     1896     1896              
==========================================
+ Hits         6962     7002      +40     
  Misses        911      911              
  Partials      475      475              
Impacted Files Coverage Δ
rsciio/blockfile/_api.py 95.31% <100.00%> (ø)
rsciio/bruker/__init__.py 100.00% <100.00%> (ø)
rsciio/bruker/_api.py 88.27% <100.00%> (ø)
rsciio/docstrings.py 100.00% <100.00%> (ø)
rsciio/semper_unf/__init__.py 100.00% <100.00%> (ø)
rsciio/semper_unf/_api.py 89.58% <100.00%> (ø)
rsciio/sur/__init__.py 100.00% <100.00%> (ø)
rsciio/sur/_api.py 71.42% <100.00%> (ø)
rsciio/tiff/__init__.py 100.00% <100.00%> (ø)
rsciio/tiff/_api.py 88.24% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jlaehne jlaehne force-pushed the doc-s-z branch 3 times, most recently from f7f6abe to 4d6a420 Compare November 5, 2022 16:07
@jlaehne jlaehne mentioned this pull request Nov 5, 2022
7 tasks
@jlaehne
Copy link
Member Author

jlaehne commented Nov 5, 2022

Working on this PR I realized that plugins have to be loaded by their folder name, which is often not the same as the plugin name:
USID - usid_hdf5
Semper - semper_unf
DigitalSurfSurface - sur

When loading in HyperSpy, the reader can be specified by the plugin name, but when loading an individual plugin one has to use the folder_name, which is not mentioned anywhere in the documentation so far! For example, from rsciio import usid_hdf5.

We may want to give the folders more consistent names that correspond to the default plugin name (capitalization is another question here) and then document the names in the table of supported formats.

@jlaehne jlaehne force-pushed the doc-s-z branch 2 times, most recently from eb54206 to 435ea41 Compare November 6, 2022 18:17
@jlaehne jlaehne force-pushed the doc-s-z branch 2 times, most recently from a1f5729 to 28a701f Compare November 6, 2022 22:37
@ericpre ericpre merged commit c667833 into hyperspy:main Nov 12, 2022
@jlaehne jlaehne deleted the doc-s-z branch November 12, 2022 20:48
@jlaehne jlaehne mentioned this pull request Nov 14, 2022
3 tasks
@jlaehne jlaehne mentioned this pull request Nov 15, 2022
7 tasks
@jlaehne jlaehne mentioned this pull request Dec 7, 2022
7 tasks
@jlaehne jlaehne mentioned this pull request Jan 16, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants