breaking-change: add nuxt-3
support
#41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Request Description
Since Vite/Rollup doesn't fully support dynamic import of node modules, I split the premium ones from defaults and add each plugin (only club plugins) to own file.
I chose that way because premium plugins are not available in the
node_modules
directory unless the user installs them manually (default ones are automatically installed when user installs gsap pkg), so importing them into the plugin (client/browser side) without dynamic imports or some kind of magic won't work.It should also be noted that GSAP offers 3 types of paid packages, including bonuses, and each package offers different plugins, so it can easily become a code mess (not all club plugins are installed with the same license).
This separation method of premium plugins seems to me to be the best option at the moment, because the user chooses which plugins want to activate. Also, all plugins, default and premium, are automatically registered and fully typed so the dev experience are great.
Additional Details
I also want to mention that I will be transferring the repository to my new Hypernym Studio organization and renaming the package to
@hypernym/nuxt-gsap
.So when the changes are merged into the main branch, the module will be installed and used with the new name, everything else remains the same:
Example
TODO
Resolves #24