-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Follow up] Add Transaction Permissioning Hook to PermissioningService Interface #8365
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com>
Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com>
…hen it already exists Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com>
Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com>
…er#7835 # Conflicts: # acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/plugins/PermissioningPluginTest.java
Signed-off-by: Vaidik <vaidikbhardwaj00@gmail.com>
Signed-off-by: Vaidik <vaidikbhardwaj00@gmail.com>
Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution! Strong preference for not modifying the smart contract permissioning code at this stage since it's about to be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've deprecated smart contract based permissioning per the sunset plan https://www.lfdecentralizedtrust.org/blog/sunsetting-tessera-and-simplifying-hyperledger-besu
so this class is going to be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and right now we're effectively in a code freeze for the sunset features. So would prefer not to modify this code if possible, and if not possible, would prefer to remove smart contract permissioning first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was indeed another thing that I wanted to mention in the first comment. I can revert that change. Should I also add @Depracted
tag? or is it not common practice here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meanwhile, I checked the latest version from main reverting the changes. Let me know if I need to do other cleanups of the previous changes.
Signed-off-by: reluc <relu.cri@gmail.com>
Signed-off-by: reluc <relu.cri@gmail.com>
Signed-off-by: reluc <relu.cri@gmail.com>
Signed-off-by: reluc <relu.cri@gmail.com>
PR description
This PR builds upon the work started in #7952, finalizing the implementation while maintaining consistency with the existing changes.
Key Updates:
Basically, after merging this work, people can filter transactions using the PermissioningService in their plugins. I would say adding some examples to the documentation might be useful.
Note: I didn't like the previous acceptance test, I found it a little bit convoluted for simply assigning the filtering mechanism of the plugins. As I said, I tried to be as conservative as I could. If you want, we can discuss possible improvements there.
Fixed Issue(s)
#7835
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests