Safely handle race condition between isEmpty() and lastKey() being called #8362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lled Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
fab-10
requested changes
Feb 28, 2025
...n/java/org/hyperledger/besu/ethereum/eth/transactions/layered/AbstractTransactionsLayer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
fab-10
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Safely handle cases where a map's
isEmpty()call returns false, but the map is updated before the call tolastKey()is made.I've looked through the rest of the codebase and fixed the one other place I think we could hit this. For other code paths that use the same combination of
isEmpty()andlastKey()I don't think they are likely to suffer from the same issue. If they do theNoSuchElementExceptionwill clearly point to where else we need to fix it.No change log entry as it's just an internal fix that nobody else has reported seeing yet.
Fixed Issue(s)
Fixes #8356