Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and re-enable CliqueProposeRpcAcceptanceTest #8324

Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Feb 18, 2025

PR description

the flakiness was due to the fact that during cluster start, when there are more validators at genesis, there could be a race condition and more that one validator could create block #1 resulting in a network fork.
The solution the is to always start with only one validator, waiting for the cluster to be in sync and then add other validators.

Fixed Issue(s)

fixes #7973

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the re-enable-CliqueProposeRpcAcceptanceTest branch from ca0d2a8 to ebfe022 Compare February 19, 2025 14:33
@fab-10 fab-10 changed the title Re-enable CliqueProposeRpcAcceptanceTest Fix and re-enable CliqueProposeRpcAcceptanceTest Feb 19, 2025
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the re-enable-CliqueProposeRpcAcceptanceTest branch from ebfe022 to 1c36fbd Compare February 19, 2025 16:11
@fab-10 fab-10 marked this pull request as ready for review February 19, 2025 16:44
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it @fab-10

@macfarla macfarla enabled auto-merge (squash) February 20, 2025 05:19
@macfarla macfarla merged commit f54e455 into hyperledger:main Feb 20, 2025
43 checks passed
@fab-10 fab-10 deleted the re-enable-CliqueProposeRpcAcceptanceTest branch February 20, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test - CliqueProposeRpcAcceptanceTest
2 participants