feat: exported metrics for current finalized and safe block number #7592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonesho
force-pushed
the
export-metrics-finalized-safe-block-number
branch
from
ba48ec1 to
dfb1ab6
Compare
fab-10
requested changes
Sep 10, 2024
There was a problem hiding this comment.
please remove this change that is not relevant
Signed-off-by: Jones Ho <jones.ho@consensys.net>
jonesho
force-pushed
the
export-metrics-finalized-safe-block-number
branch
from
dfb1ab6 to
47a5166
Compare
fab-10
reviewed
Sep 10, 2024
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchain.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchain.java
Outdated
Show resolved
Hide resolved
…n/DefaultBlockchain.java Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jonesho <81145364+jonesho@users.noreply.github.com>
…n/DefaultBlockchain.java Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jonesho <81145364+jonesho@users.noreply.github.com>
fab-10
approved these changes
Sep 10, 2024
Signed-off-by: Jones Ho <jones.ho@consensys.net>
auto-merge was automatically disabled
September 10, 2024 09:35
Head branch was pushed to by a user without write access
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
fixes #7564
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests