CLI option for disabling auto-registration of external plugins #7470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Matilda-Clerke
approved these changes
Aug 16, 2024
besu/src/main/java/org/hyperledger/besu/services/BesuPluginContextImpl.java
Outdated
Show resolved
Hide resolved
macfarla
approved these changes
Aug 16, 2024
besu/src/main/java/org/hyperledger/besu/cli/DefaultCommandValues.java
Outdated
Show resolved
Hide resolved
jframe
reviewed
Aug 16, 2024
besu/src/main/java/org/hyperledger/besu/cli/DefaultCommandValues.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
…el-Trintinalia/besu into plugin-auto-detection-flag
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
… options are used Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
…el-Trintinalia/besu into plugin-auto-detection-flag
Gabriel-Trintinalia
changed the title
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jframe
approved these changes
Aug 16, 2024
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
…el-Trintinalia/besu into plugin-auto-detection-flag
cloudspores
pushed a commit
to cloudspores/besu
that referenced
this pull request
Aug 23, 2024
…ledger#7470) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
…ledger#7470) Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This pull request introduces a new flag to provide more granular control over plugin registration in Besu. While Besu currently allows specifying individual plugins to load, it does not offer an option to disable the automatic registration of external plugins. This new flag will enable users to disable external plugins, offering greater flexibility in managing plugin configurations.
Usage
Enable external plugins (Default):
Disable external plugins:
The new flag defaults to enabled, ensuring no breaking changes to existing setups. At this stage, the flag is kept hidden as it is experimental.