Add a sender cache to Transaction

CHANGELOG.md

@@ -15,6 +15,7 @@
 - Add custom genesis file name to config overview if specified [#6297](https://github.com/hyperledger/besu/pull/6297)
 - Update Gradle plugins and replace unmaintained License Gradle Plugin with the actively maintained Gradle License Report [#6275](https://github.com/hyperledger/besu/pull/6275)
 - Optimize RocksDB WAL files, allows for faster restart and a more linear disk space utilization [#6328](https://github.com/hyperledger/besu/pull/6328)
+- Add a cache on senders by transaction hash [#6375](https://github.com/hyperledger/besu/pull/6375)
 
 ### Bug fixes
 - INTERNAL_ERROR from `eth_estimateGas` JSON/RPC calls [#6344](https://github.com/hyperledger/besu/issues/6344)

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/AbstractEngineNewPayload.java

@@ -25,6 +25,7 @@
 import static org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.RpcErrorType.INVALID_PARAMS;
 
 import org.hyperledger.besu.consensus.merge.blockcreation.MergeMiningCoordinator;
+import org.hyperledger.besu.datatypes.Address;
 import org.hyperledger.besu.datatypes.BlobGas;
 import org.hyperledger.besu.datatypes.Hash;
 import org.hyperledger.besu.datatypes.VersionedHash;
@@ -68,6 +69,7 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
 import java.util.stream.Collectors;
 
 import io.vertx.core.Vertx;
@@ -178,6 +180,17 @@ public JsonRpcResponse syncResponse(final JsonRpcRequestContext requestContext)
               .map(Bytes::fromHexString)
               .map(in -> TransactionDecoder.decodeOpaqueBytes(in, EncodingContext.BLOCK_BODY))
               .collect(Collectors.toList());
+      transactions.forEach(
+          transaction ->
+              CompletableFuture.runAsync(
+                  () -> {
+                    Address sender = transaction.getSender();
+                    LOG.atTrace()
+                        .setMessage("The sender for transaction {} is calculated : {}")
+                        .addArgument(transaction.getHash())
+                        .addArgument(sender)
+                        .log();
+                  }));
     } catch (final RLPException | IllegalArgumentException e) {
       return respondWithInvalid(
           reqId,

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java

@@ -51,6 +51,8 @@
 import java.util.Objects;
 import java.util.Optional;
 
+import com.google.common.cache.Cache;
+import com.google.common.cache.CacheBuilder;
 import com.google.common.primitives.Longs;
 import org.apache.tuweni.bytes.Bytes;
 import org.apache.tuweni.bytes.Bytes32;
@@ -75,6 +77,9 @@ public class Transaction
 
   public static final BigInteger TWO = BigInteger.valueOf(2);
 
+  private static final Cache<Hash, Address> senderCache =
+      CacheBuilder.newBuilder().recordStats().maximumSize(100_000L).build();
+
   private final long nonce;
 
   private final Optional<Wei> gasPrice;
@@ -411,14 +416,21 @@ public Optional<BigInteger> getChainId() {
   @Override
   public Address getSender() {
     if (sender == null) {
-      final SECPPublicKey publicKey =
-          signatureAlgorithm
-              .recoverPublicKeyFromSignature(getOrComputeSenderRecoveryHash(), signature)
-              .orElseThrow(
-                  () ->
-                      new IllegalStateException(
-                          "Cannot recover public key from signature for " + this));
-      sender = Address.extract(Hash.hash(publicKey.getEncodedBytes()));
+      Optional<Address> cachedSender = Optional.ofNullable(senderCache.getIfPresent(getHash()));
+      sender =
+          cachedSender.orElseGet(
+              () -> {
+                final SECPPublicKey publicKey =
+                    signatureAlgorithm
+                        .recoverPublicKeyFromSignature(getOrComputeSenderRecoveryHash(), signature)
+                        .orElseThrow(
+                            () ->
+                                new IllegalStateException(
+                                    "Cannot recover public key from signature for " + this));
+                Address calculatedSender = Address.extract(Hash.hash(publicKey.getEncodedBytes()));
+                senderCache.put(this.hash, calculatedSender);
+                return calculatedSender;
+              });
     }
     return sender;
   }