getByBlockNumber replaced by getByBlockHeader on tests #5259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
# Conflicts: # ethereum/core/src/test/java/org/hyperledger/besu/ethereum/mainnet/ProtocolScheduleBuilderTest.java
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
|
siladu
approved these changes
Mar 23, 2023
| @@ -27,6 +30,8 @@ | |||
|
|
|||
| public class MergeProtocolScheduleTest { | |||
|
|
|||
| final BlockDataGenerator blockDataGenerator = new BlockDataGenerator(); | |||
There was a problem hiding this comment.
Removed. Thanks!
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
jframe
reviewed
Mar 23, 2023
| @@ -256,4 +257,8 @@ private BftConfigOptions createBftConfig( | |||
|
|
|||
| return bftConfig; | |||
| } | |||
|
|
|||
| private BlockHeader blockHeader(final long number) { | |||
There was a problem hiding this comment.
This is used a lot in tests, might be nice to have this as a static method in the BlockHeaderTestFixture
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
) * Replace getByBlockNumber by getByBlockHeader Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace getByBlockNumber by getByBlockHeader Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace BlockDataGenerator by BlockHeaderTestFixture Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace BlockDataGenerator by BlockHeaderTestFixture Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add final to method param Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace BlockDataGEnerator by BlockHeaderTestFixture Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace BlockDataGenerator by BlockHeaderTestFixture Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Remove BlockDataGenerator Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
) * Replace getByBlockNumber by getByBlockHeader Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace getByBlockNumber by getByBlockHeader Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace BlockDataGenerator by BlockHeaderTestFixture Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace BlockDataGenerator by BlockHeaderTestFixture Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add final to method param Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace BlockDataGEnerator by BlockHeaderTestFixture Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace BlockDataGenerator by BlockHeaderTestFixture Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Remove BlockDataGenerator Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR removes the getByBlockNumber from tests and replace it's usage by getByBlockHeader.
Fixed Issue(s)
Fixes #5165